From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <junkio@cox.net>, Nicolas Pitre <nico@cam.org>,
git@vger.kernel.org
Subject: Re: [PATCH] shortlog: fix segfault on empty authorname
Date: Sat, 9 Dec 2006 22:45:24 -0500 [thread overview]
Message-ID: <20061210034524.GA11819@coredump.intra.peff.net> (raw)
In-Reply-To: <Pine.LNX.4.63.0612100019270.28348@wbgn013.biozentrum.uni-wuerzburg.de>
On Sun, Dec 10, 2006 at 12:21:03AM +0100, Johannes Schindelin wrote:
> > Instead, remove at most one space between name and address.
>
> Why? We can fix it properly: Instead of
>
> > - while (isspace(bob[-1]))
> > + if (isspace(bob[-1]))
>
> do something like
>
> while (bob - 1 != buffer + 7 &&
> isspace(bob[-1]))
It doesn't look like there are ever extra spaces to get soaked up in the
kernel or git repositories, but if there is a reason to expect
Full Name <user@domain>
then we should probably replace my fix with yours.
next prev parent reply other threads:[~2006-12-10 3:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-09 3:23 builtin git-shortlog still broken Nicolas Pitre
2006-12-09 4:04 ` [PATCH] shortlog: fix segfault on empty authorname Jeff King
2006-12-09 21:56 ` Nicolas Pitre
2006-12-09 23:21 ` Johannes Schindelin
2006-12-10 3:45 ` Jeff King [this message]
2006-12-10 6:01 ` Junio C Hamano
2006-12-10 22:43 ` Johannes Schindelin
2006-12-09 23:34 ` builtin git-shortlog still broken Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061210034524.GA11819@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).