git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: fork0@t-online.de (Alex Riesen)
To: Marco Costalba <mcostalba@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Easy shell question: how to make a script killing all his childs when killed?
Date: Sun, 10 Dec 2006 15:25:58 +0100	[thread overview]
Message-ID: <20061210142558.GA4836@steel.home> (raw)
In-Reply-To: <e5bfff550612091506g41e40e87n6356b8ddd5e16a5d@mail.gmail.com>

Marco Costalba, Sun, Dec 10, 2006 00:06:34 +0100:
> On 12/9/06, Alex Riesen <fork0@t-online.de> wrote:
> >
> >Why do you need to save it in temporary file at all? Why don't you
> >read the output like gitk does?  You can take a look at popen(3). It's
> >known to be portable among operating systems and libc's.  Or, BTW, why
> >don't you just read qprocess.h, use processIdentifier()/pid(),
> >read*()-methods and the like?  (though, looking at the QProcess in
> >qt3, I wouldn't really blame you)
> >
> 
> Well, I _used_ QProcess interface until last week. It's socket based
> and it's quite fast (much more then gitk BTW), but due to some
> internal buffering not so fast as reading from a file (in my last post
> regarding git-rev-list access there are some performance numbers to
> document this). It seems that socket/pipe based IPC is not as fast as
> file write/read. Of course we are talking of OS cached files, no disk
> access must be involved to keep the speed.

Oh, I see now ("Fast access git-rev-list output...").

BTW, I just cannot reproduce that at all (on Linux):

    time { git rev-list --all > /tmp/ggg; cat /tmp/ggg >/dev/null; }

tends to be somewhat slower than

    time git rev-list --all | cat >/dev/null

QProcess must be doing something stupid.

> Regarding gitk we are at least one order of magnitude faster both with
> QProcess and, more, with temporary files, so it's not a useful
> reference in this case.

Dunno. It's hard to assess on "small" repos, like kernel. They feel
almost equally fast (maybe because qgit checks working directory too).
Haven't tried QGit on Windows yet (does it work there?).

> P.S: I didn't experiment with popen(). Thanks for the hint, I will
> give it a try ;-)

popen(3) usually uses pipe(2). It's also awkward with regard to
shell metacharacters and signals (as system(3) is). You can use your'
own buffers (setvbuf) so that could be a win against QProcess.

      reply	other threads:[~2006-12-10 14:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-09 15:16 Easy shell question: how to make a script killing all his childs when killed? Marco Costalba
2006-12-09 17:37 ` Alex Riesen
2006-12-09 17:51   ` Marco Costalba
2006-12-09 21:39     ` Alex Riesen
2006-12-09 23:06       ` Marco Costalba
2006-12-10 14:25         ` Alex Riesen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061210142558.GA4836@steel.home \
    --to=fork0@t-online.de \
    --cc=git@vger.kernel.org \
    --cc=mcostalba@gmail.com \
    --cc=raa.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).