From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Andy Parkins <andyparkins@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] "master" should be treated no differently from any other branch
Date: Thu, 14 Dec 2006 19:35:49 +0100 [thread overview]
Message-ID: <200612141935.49776.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <20061214174251.GA16819@tuxdriver.com>
torsdag 14 december 2006 18:42 skrev John W. Linville:
> On Thu, Dec 14, 2006 at 03:19:44PM +0000, Andy Parkins wrote:
> > This patch makes all merge log messages of the form:
> >
> > Merge branch XXXX into YYYY
> >
> > Regardless of whether YYYY is master or not.
> >
> > "master" shouldn't get special treatment; making different log messages
> > based on the name of the branch is bad form. What if a user likes
> > "my/master" or "my/head" as their master branch?
>
> Why not drop the "into YYYY" part for everyone else? I don't find
> it useful at all, and is just confusing if I merge to a temporary
> branch and then pull that into master later.
Or just drop both the from, into and repo names.. A commit may come from a
certain repo, buy you would never know since it may have been pulled there
rather than committed, so the merge message is misleading and if the merge
was a fast forward you wouldn't see a merge message at all.
To make everybody happy, the .git/config could contain a template that states
the project policy on merge commits.
Obviously the person executing the merge is free to amend the merge message,
insertering synthetic commits or whatever he/she sees fit.
next prev parent reply other threads:[~2006-12-14 18:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 15:19 [PATCH] "master" should be treated no differently from any other branch Andy Parkins
2006-12-14 15:29 ` Johannes Schindelin
2006-12-14 15:47 ` Han-Wen Nienhuys
2006-12-14 15:57 ` Johannes Schindelin
2006-12-14 15:59 ` Han-Wen Nienhuys
2006-12-14 16:14 ` Johannes Schindelin
2006-12-15 10:29 ` Jakub Narebski
2006-12-14 18:22 ` Nicolas Pitre
2006-12-14 16:20 ` Jerome Lovy
2006-12-15 21:55 ` Junio C Hamano
2006-12-14 16:25 ` Andy Parkins
2006-12-14 16:34 ` Andy Parkins
2006-12-14 16:39 ` Johannes Schindelin
2006-12-14 17:42 ` John W. Linville
2006-12-14 18:35 ` Robin Rosenberg [this message]
2006-12-14 20:41 ` Junio C Hamano
2006-12-14 21:23 ` Andy Parkins
2006-12-14 21:30 ` Junio C Hamano
2006-12-14 21:37 ` Andy Parkins
2006-12-14 21:57 ` Shawn Pearce
2006-12-15 10:35 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612141935.49776.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).