git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Pearce <spearce@spearce.org>
To: Geert Bosch <bosch@adacore.com>
Cc: Andreas Ericsson <ae@op5.se>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Andy Parkins <andyparkins@gmail.com>,
	git@vger.kernel.org
Subject: Re: git-fetching from a big repository is slow
Date: Thu, 14 Dec 2006 14:46:36 -0500	[thread overview]
Message-ID: <20061214194636.GO1747@spearce.org> (raw)
In-Reply-To: <C287764F-6755-4291-A87A-3E8816E90B49@adacore.com>

Geert Bosch <bosch@adacore.com> wrote:
> Such special magic based on filenames is always a bad idea. Tomorrow  
> somebody
> comes with .zip files (oh, and of course .ZIP), then it's .jpg's other
> compressed content. In the end git will be doing lots of magic and  
> still perform
> badly on unknown compressed content.
> 
> There is a very simple way of detecting compressed files: just look  
> at the
> size of the compressed blob and compare against the size of the  
> expanded blob.
> If the compressed blob has a non-trivial size which is close to the  
> expanded
> size, assume the file is not interesting as source or target for deltas.
> 
> Example:
>    if (compressed_size > expanded_size / 4 * 3 + 1024) {
>      /* don't try to deltify if blob doesn't compress well */
>      return ...;
>    }

And yet I get good delta compression on a number of ZIP formatted
files which don't get good additional zlib compression (<3%).
Doing the above would cause those packfiles to explode to about
10x their current size.

-- 

  reply	other threads:[~2006-12-14 19:46 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-14 13:40 git-fetching from a big repository is slow Andy Parkins
2006-12-14 13:53 ` Andreas Ericsson
2006-12-14 14:14   ` Johannes Schindelin
2006-12-14 15:06     ` Andreas Ericsson
2006-12-14 19:05       ` Geert Bosch
2006-12-14 19:46         ` Shawn Pearce [this message]
2006-12-14 22:12           ` Horst H. von Brand
2006-12-14 22:38             ` Shawn Pearce
2006-12-15 21:49               ` Pazu
2006-12-16 13:32                 ` Robin Rosenberg
2006-12-14 23:01           ` Geert Bosch
2006-12-14 23:15           ` Johannes Schindelin
2006-12-14 23:29             ` Shawn Pearce
2006-12-15  0:07               ` Johannes Schindelin
2006-12-15  0:42                 ` Shawn Pearce
2006-12-15  2:26             ` Nicolas Pitre
2006-12-14 22:28         ` Andreas Ericsson
2006-12-14 15:18   ` Andy Parkins
2006-12-14 15:45     ` Han-Wen Nienhuys
2006-12-14 16:20       ` Andy Parkins
2006-12-14 16:34         ` Johannes Schindelin
2006-12-14 20:41           ` Junio C Hamano
2006-12-14 23:26             ` Johannes Schindelin
2006-12-15  0:38               ` Junio C Hamano
2006-12-14 18:14   ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061214194636.GO1747@spearce.org \
    --to=spearce@spearce.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=ae@op5.se \
    --cc=andyparkins@gmail.com \
    --cc=bosch@adacore.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).