From: Shawn Pearce <spearce@spearce.org>
To: Nicolas Pitre <nico@cam.org>
Cc: Junio C Hamano <junkio@cox.net>,
git@vger.kernel.org, Andy Parkins <andyparkins@gmail.com>
Subject: Re: [PATCH] Stop telling users we are 'defaulting to local storage area'.
Date: Thu, 14 Dec 2006 21:25:43 -0500 [thread overview]
Message-ID: <20061215022543.GL26202@spearce.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0612142059301.18171@xanadu.home>
Nicolas Pitre <nico@cam.org> wrote:
> On Thu, 14 Dec 2006, Shawn O. Pearce wrote:
> > It also breaks from our normal behavior of not printing
> > anything if the command was successful.
> I really don't think this is a good rule.
>
> NOte that I'm not against commands that are silent by default. I really
> think that git-add should remain silent on success by default when
> successful.
>
> But the rule of thumb should be about the importance of the action
> performed by the command.
> But git-init-db is really important.
A very reasonable argument, butchered for my evil quoting needs. :-)
If we want to keep letting git-init-db output something, then
the output should be a lot more meaningful to the average English
speaking new Git user than "defaulting to local storage area".
E.g.:
$ git init-db
Initialized empty Git repository in .git/
would probably make a lot more sense to new and expert users alike.
I'm fine with the above form, I just think that the message we have
now could benefit from being sent to the land from which there is
no return, or be rewritten...
BTW, I almost also submitted a patch to remove the "Committing
initial tree ..." message in git-commit-tree, but thought twice about
it as committing an initial tree is sort of an important difference
from normal activity that we should highlight it somehow...
--
next prev parent reply other threads:[~2006-12-15 2:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 23:09 [PATCH] Stop telling users we are 'defaulting to local storage area' Shawn O. Pearce
2006-12-15 2:18 ` Nicolas Pitre
2006-12-15 2:25 ` Shawn Pearce [this message]
2006-12-15 2:43 ` Nicolas Pitre
2006-12-15 5:44 ` [PATCH] Provide more meaningful output from 'git init-db' Shawn O. Pearce
2006-12-15 14:14 ` Jakub Narebski
2006-12-15 14:59 ` Shawn Pearce
2006-12-19 19:48 ` [PATCH] Stop telling users we are 'defaulting to local storagearea' David Lang
2006-12-15 14:10 ` [PATCH] Stop telling users we are 'defaulting to local storage area' Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061215022543.GL26202@spearce.org \
--to=spearce@spearce.org \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).