From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <junkio@cox.net>
Subject: Re: [RFC/PATCH] Implement poor-man's submodule support in pre-commit hook
Date: Thu, 21 Dec 2006 08:39:34 +0000 [thread overview]
Message-ID: <200612210839.35980.andyparkins@gmail.com> (raw)
In-Reply-To: <7vslfae4uv.fsf@assigned-by-dhcp.cox.net>
On Wednesday 2006 December 20 19:37, Junio C Hamano wrote:
> I do not think these are insurmountable.
Me either. I wasn't really sure how warmly these patches would be received,
so thought some small patches that make the feature highly might be more
palatable. I actually don't think that the hook templates is the right place
for this work; submodule support is not something you would customise
per-repository, and so the hook scripts are manifestly the wrong place for
this.
> As you fix them and enhance the support, I suspect you would
> want a separate command to manage .gitmodule file and submodules
> referenced by it. I think it would be better to keep the patch
> to the template to the minimum (for example, run "git submodule
> update" if there is .gitmodules file at the toplevel), and
> implement the body of the processing in "git-submodule.sh", or
> something like that.
That's an interesting idea. I was thinking that git-commit itself would have
been the final target; but I certainly don't have any problem with a separate
command.
Andy
--
Dr Andy Parkins, M Eng (hons), MIEE
andyparkins@gmail.com
next prev parent reply other threads:[~2006-12-21 8:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-20 9:01 [RFC/PATCH] Implement poor-man's submodule support in pre-commit hook Andy Parkins
2006-12-20 10:08 ` Andy Parkins
2006-12-20 11:49 ` Brian Gernhardt
2006-12-20 12:01 ` Jakub Narebski
2006-12-20 12:35 ` Andreas Ericsson
2006-12-20 14:47 ` [BUG] git --git-dir dies with bus error Brian Gernhardt
2006-12-20 11:59 ` [RFC/PATCH] Implement poor-man's submodule support in pre-commit hook Jakub Narebski
2006-12-20 12:11 ` Andy Parkins
2006-12-20 19:37 ` Junio C Hamano
2006-12-21 8:39 ` Andy Parkins [this message]
2006-12-21 8:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612210839.35980.andyparkins@gmail.com \
--to=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).