git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* git-svn dcommit ignors svn.authorsfile config and -A / --author-file cmd-line-option
@ 2006-12-22 12:28 Nicolas Vilz
  2006-12-23  5:59 ` [PATCH] git-svn: enable common fetch/commit options for dcommit Eric Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Vilz @ 2006-12-22 12:28 UTC (permalink / raw)
  To: git

Hello again,

I wonder, if git dcommit supports the option or the repo-config key
svn.authors.file... i think it does not, or i do something wrong...

<username> = <name> <email>

did work on git-svn fetch iirc ... but does it on git-svn dcommit, too?

Sincerly
Nicolas

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] git-svn: enable common fetch/commit options for dcommit
  2006-12-22 12:28 git-svn dcommit ignors svn.authorsfile config and -A / --author-file cmd-line-option Nicolas Vilz
@ 2006-12-23  5:59 ` Eric Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2006-12-23  5:59 UTC (permalink / raw)
  To: Nicolas Vilz; +Cc: Junio C Hamano, git

dcommit does commits and fetches, so all options used for those
should work, too, including --authors-file.

Reported missing by Nicolas Vilz.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 git-svn.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-svn.perl b/git-svn.perl
index 07748bc..4288a05 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -111,7 +111,7 @@ my %cmd = (
 			{ 'merge|m|M' => \$_merge,
 			  'strategy|s=s' => \$_strategy,
 			  'dry-run|n' => \$_dry_run,
-			%cmt_opts } ],
+			%cmt_opts, %fc_opts } ],
 	'set-tree' => [ \&commit, "Set an SVN repository to a git tree-ish",
 			{	'stdin|' => \$_stdin, %cmt_opts, %fc_opts, } ],
 	'show-ignore' => [ \&show_ignore, "Show svn:ignore listings",
-- 
1.4.4.3.gc902c

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-12-23  5:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-22 12:28 git-svn dcommit ignors svn.authorsfile config and -A / --author-file cmd-line-option Nicolas Vilz
2006-12-23  5:59 ` [PATCH] git-svn: enable common fetch/commit options for dcommit Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).