From: Shawn Pearce <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Create 'git gc' to perform common maintenance operations.
Date: Wed, 27 Dec 2006 03:33:28 -0500 [thread overview]
Message-ID: <20061227083328.GD23022@spearce.org> (raw)
In-Reply-To: <7vhcvh922r.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> Shawn Pearce <spearce@spearce.org> writes:
>
> > I don't care either way. 60 days may be too long for some users,
> > but for others it may be nice to have. I think the two defaults
> > should match just because. Feel free to edit my patch before
> > applying to be whatever 'git-reflog expire' uses if you want.
>
> I think the built-in git-reflog should be updated to honor the
> configuration in the absense of command line options; if we do
> that git-gc.sh does not even have to call repo-config anymore.
Sure, but then maybe the configuration options shouldn't be
'gc.reflog*' but instead 'reflog.*'.
git-gc.sh was a quick hack while I was waiting for that huge disk
IO to repack a git.git with 1.3.3. I was trying to avoid hacking
C code for it, but you are probably right, better to just make the
C code do the right thing from "day one".
--
Shawn.
next prev parent reply other threads:[~2006-12-27 8:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-27 7:17 [PATCH] Create 'git gc' to perform common maintenance operations Shawn O. Pearce
2006-12-27 7:46 ` Junio C Hamano
2006-12-27 7:53 ` Shawn Pearce
2006-12-27 8:26 ` Junio C Hamano
2006-12-27 8:33 ` Shawn Pearce [this message]
2006-12-27 9:10 ` Junio C Hamano
2006-12-27 13:11 ` Martin Waitz
2006-12-27 18:46 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2006-12-27 7:05 Shawn O. Pearce
2006-12-27 7:12 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061227083328.GD23022@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).