From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: [PATCH 1/2] Teach Git how to parse standard power of 2 suffixes.
Date: Sat, 30 Dec 2006 21:02:18 -0500 [thread overview]
Message-ID: <20061231020218.GA5366@spearce.org> (raw)
Sometimes its necessary to supply a value as a power of two in a
configuration parameter. In this case the user may want to use
the standard suffixes such as K, KB, KiB, etc. to indicate that
the numerical value should be multiplied by a constant base before
being used.
The new git_config_datasize function can be used in config file
handler functions to obtain a size_t in bytes.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
Applies on top of sp/mmap, but was broken out to make it easier
to apply earlier in case someone else needed this function.
cache.h | 1 +
config.c | 25 +++++++++++++++++++++++++
2 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/cache.h b/cache.h
index a5fc232..abbcab3 100644
--- a/cache.h
+++ b/cache.h
@@ -418,6 +418,7 @@ extern int git_config_from_file(config_fn_t fn, const char *);
extern int git_config(config_fn_t fn);
extern int git_config_int(const char *, const char *);
extern int git_config_bool(const char *, const char *);
+extern size_t git_config_datasize(const char *, const char *);
extern int git_config_set(const char *, const char *);
extern int git_config_set_multivar(const char *, const char *, const char *, int);
extern int git_config_rename_section(const char *, const char *);
diff --git a/config.c b/config.c
index 2e0d5a8..07ad2f1 100644
--- a/config.c
+++ b/config.c
@@ -255,6 +255,31 @@ int git_config_bool(const char *name, const char *value)
return git_config_int(name, value) != 0;
}
+size_t git_config_datasize(const char *name, const char *value)
+{
+ if (value && *value) {
+ char *end;
+ unsigned long val = strtoul(value, &end, 0);
+ while (isspace(*end))
+ end++;
+ if (!*end)
+ return val;
+ if (!strcasecmp(end, "k")
+ || !strcasecmp(end, "kb")
+ || !strcasecmp(end, "kib"))
+ return val * 1024;
+ if (!strcasecmp(end, "m")
+ || !strcasecmp(end, "mb")
+ || !strcasecmp(end, "mib"))
+ return val * 1024 * 1024;
+ if (!strcasecmp(end, "g")
+ || !strcasecmp(end, "gb")
+ || !strcasecmp(end, "gib"))
+ return val * 1024 * 1024 * 1024;
+ }
+ die("bad config value for '%s' in %s", name, config_file_name);
+}
+
int git_default_config(const char *var, const char *value)
{
/* This needs a better name */
--
1.5.0.rc0.g6bb1
next reply other threads:[~2006-12-31 2:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-31 2:02 Shawn O. Pearce [this message]
2006-12-31 2:33 ` [PATCH 1/2] Teach Git how to parse standard power of 2 suffixes Junio C Hamano
2006-12-31 2:38 ` Shawn Pearce
2006-12-31 2:57 ` Junio C Hamano
2006-12-31 3:01 ` Shawn Pearce
2006-12-31 5:38 ` Junio C Hamano
2006-12-31 5:47 ` Shawn O. Pearce
-- strict thread matches above, loose matches on Subject: below --
2006-12-31 3:13 Shawn O. Pearce
2006-12-31 5:56 ` Junio C Hamano
2006-12-31 6:12 ` Shawn O. Pearce
2006-12-31 6:23 ` Junio C Hamano
2006-12-31 6:26 ` Shawn O. Pearce
2006-12-31 6:30 ` Junio C Hamano
2006-12-31 6:36 ` Shawn O. Pearce
2006-12-31 6:48 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061231020218.GA5366@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).