From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: [PATCH 1/2] Teach Git how to parse standard power of 2 suffixes.
Date: Sat, 30 Dec 2006 22:13:05 -0500 [thread overview]
Message-ID: <20061231031305.GA5620@spearce.org> (raw)
Sometimes its necessary to supply a value as a power of two in a
configuration parameter. In this case the user may want to use the
standard suffixes such as K, M, or G to indicate that the numerical
value should be multiplied by a constant base before being used.
Shell scripts/etc. can also benefit from this automatic option
parsing with `git repo-config --int`.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
This is a resend of the prior version of this patch. Junio
convinced me on #git that this version might be better. :-)
Meant for the top of sp/mmap, but may be useful elsewhere.
Documentation/git-repo-config.txt | 5 ++++-
config.c | 8 ++++++++
2 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/Documentation/git-repo-config.txt b/Documentation/git-repo-config.txt
index b379ec5..c55a8ba 100644
--- a/Documentation/git-repo-config.txt
+++ b/Documentation/git-repo-config.txt
@@ -87,7 +87,10 @@ OPTIONS
git-repo-config will ensure that the output is "true" or "false"
--int::
- git-repo-config will ensure that the output is a simple decimal number
+ git-repo-config will ensure that the output is a simple
+ decimal number. An optional value suffix of 'k', 'm', or 'g'
+ in the config file will cause the value to be multiplied
+ by 1024, 1048576, or 1073741824 prior to output.
ENVIRONMENT
diff --git a/config.c b/config.c
index 2e0d5a8..83ce9e1 100644
--- a/config.c
+++ b/config.c
@@ -236,8 +236,16 @@ int git_config_int(const char *name, const char *value)
if (value && *value) {
char *end;
int val = strtol(value, &end, 0);
+ while (isspace(*end))
+ end++;
if (!*end)
return val;
+ if (!strcasecmp(end, "k"))
+ return val * 1024;
+ if (!strcasecmp(end, "m"))
+ return val * 1024 * 1024;
+ if (!strcasecmp(end, "g"))
+ return val * 1024 * 1024 * 1024;
}
die("bad config value for '%s' in %s", name, config_file_name);
}
--
1.5.0.rc0.g6bb1
next reply other threads:[~2006-12-31 3:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-31 3:13 Shawn O. Pearce [this message]
2006-12-31 5:56 ` [PATCH 1/2] Teach Git how to parse standard power of 2 suffixes Junio C Hamano
2006-12-31 6:12 ` Shawn O. Pearce
2006-12-31 6:23 ` Junio C Hamano
2006-12-31 6:26 ` Shawn O. Pearce
2006-12-31 6:30 ` Junio C Hamano
2006-12-31 6:36 ` Shawn O. Pearce
2006-12-31 6:48 ` Shawn O. Pearce
-- strict thread matches above, loose matches on Subject: below --
2006-12-31 2:02 Shawn O. Pearce
2006-12-31 2:33 ` Junio C Hamano
2006-12-31 2:38 ` Shawn Pearce
2006-12-31 2:57 ` Junio C Hamano
2006-12-31 3:01 ` Shawn Pearce
2006-12-31 5:38 ` Junio C Hamano
2006-12-31 5:47 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061231031305.GA5620@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).