From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Teach Git how to parse standard power of 2 suffixes.
Date: Sun, 31 Dec 2006 01:12:32 -0500 [thread overview]
Message-ID: <20061231061232.GC6106@spearce.org> (raw)
In-Reply-To: <7vy7ooip6y.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> > diff --git a/config.c b/config.c
> > index 2e0d5a8..83ce9e1 100644
> > --- a/config.c
> > +++ b/config.c
> > @@ -236,8 +236,16 @@ int git_config_int(const char *name, const char *value)
> > if (value && *value) {
> > char *end;
> > int val = strtol(value, &end, 0);
> > + while (isspace(*end))
> > + end++;
>
> Why? Are you allowing "1024 k"? Do we want to?
Yes. Why not?
--
Shawn.
next prev parent reply other threads:[~2006-12-31 6:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-31 3:13 [PATCH 1/2] Teach Git how to parse standard power of 2 suffixes Shawn O. Pearce
2006-12-31 5:56 ` Junio C Hamano
2006-12-31 6:12 ` Shawn O. Pearce [this message]
2006-12-31 6:23 ` Junio C Hamano
2006-12-31 6:26 ` Shawn O. Pearce
2006-12-31 6:30 ` Junio C Hamano
2006-12-31 6:36 ` Shawn O. Pearce
2006-12-31 6:48 ` Shawn O. Pearce
-- strict thread matches above, loose matches on Subject: below --
2006-12-31 2:02 Shawn O. Pearce
2006-12-31 2:33 ` Junio C Hamano
2006-12-31 2:38 ` Shawn Pearce
2006-12-31 2:57 ` Junio C Hamano
2006-12-31 3:01 ` Shawn Pearce
2006-12-31 5:38 ` Junio C Hamano
2006-12-31 5:47 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061231061232.GC6106@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).