git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, Nicholas Miell <nmiell@gmail.com>
Subject: Re: [PATCH] Fix infinite loop when deleting multiple packed refs.
Date: Thu, 4 Jan 2007 22:04:26 -0500	[thread overview]
Message-ID: <20070105030426.GD14042@spearce.org> (raw)
In-Reply-To: <7vy7oluthy.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> > Nicholas Miell reported that `git branch -D A B` failed if both refs
> > A and B were packed into .git/packed-refs.  This happens because the
> > same pack_lock instance was being enqueued into the lock list twice,
> 
> I do not like this, actually.
[snip]
> In other words, I am suspecting this might be a cleaner fix.

Ack'd.  I like your patch better.

-- 
Shawn.

      reply	other threads:[~2007-01-05  3:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-02  6:44 infinite loop with git branch -D and packed-refs Nicholas Miell
2007-01-02  8:17 ` [PATCH] Fix infinite loop when deleting multiple packed refs Shawn O. Pearce
2007-01-02  8:44   ` Junio C Hamano
2007-01-02  8:47     ` Shawn O. Pearce
2007-01-02 19:19   ` Junio C Hamano
2007-01-05  3:04     ` Shawn O. Pearce [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070105030426.GD14042@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=nmiell@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).