git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: OT: character encodings (was: Linux 2.6.20-rc4)
       [not found]               ` <20070107200553.GA15101@redhat.com>
@ 2007-01-07 20:15                 ` Sean
  2007-01-07 20:40                   ` Jan Engelhardt
  0 siblings, 1 reply; 4+ messages in thread
From: Sean @ 2007-01-07 20:15 UTC (permalink / raw)
  To: Dave Jones
  Cc: Alan, David Woodhouse, Tilman Schmidt, Linux Kernel Mailing List,
	git

On Sun, 7 Jan 2007 15:05:53 -0500
Dave Jones <davej@redhat.com> wrote:

Including the Git list...

> On Sun, Jan 07, 2007 at 07:17:30PM +0000, Russell King wrote:
> 
>  > commit 24ebead82bbf9785909d4cf205e2df5e9ff7da32
>  > tree 921f686860e918a01c3d3fb6cd106ba82bf4ace6
>  > parent 264166e604a7e14c278e31cadd1afb06a7d51a11
>  > author Rafa³ Bilski <rafalbilski@interia.pl> 1167691774 +0100
>  > committer Dave Jones <davej@redhat.com> 1167799119 -0500
>  > 
>  > and looking at that "author" closer with od:
>  > 
>  > 0000140 74 68 6f 72 20 52 61 66 61 b3 20 42 69 6c 73 6b
>  >           t   h   o   r       R   a   f   a   ³       B   i   l   s   k
>  > 
>  > clearly not UTF-8.  I doubt whether any of the commits I do on my
>  > en_GB ISO-8859-1 systems end up being UTF-8 encoded.
> 
> This has been bugging me for a while.
> Viewing the mail I applied in mutt shows his name correctly as Rafał
> Applying it with git-applymbox and viewing the log on master.kernel.org
> with git log shows Rafa<B3>   And then later when put into email
> it turns into Rafa³
> 
>  > But the point is there is charset damage which has happened _long_ before
>  > Linus' action.  There is no character set defined for the contents of git
>  > repositories, and as such the output of the git tools can not be
>  > interpreted as any one single character set.
> 
> If there's something I should be doing when I commit that I'm not,
> I'll be happy to change my scripts.  My $LANG is set to en_US.UTF-8
> which should DTRT to the best of my knowledge, but clearly, that isn't
> the case.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: OT: character encodings (was: Linux 2.6.20-rc4)
  2007-01-07 20:15                 ` OT: character encodings (was: Linux 2.6.20-rc4) Sean
@ 2007-01-07 20:40                   ` Jan Engelhardt
  2007-01-07 21:07                     ` Xavier Bestel
  0 siblings, 1 reply; 4+ messages in thread
From: Jan Engelhardt @ 2007-01-07 20:40 UTC (permalink / raw)
  To: Sean
  Cc: Dave Jones, Alan, David Woodhouse, Tilman Schmidt,
	Linux Kernel Mailing List, git


>On Sun, 7 Jan 2007 15:05:53 -0500
>Dave Jones <davej@redhat.com> wrote:
>
>> If there's something I should be doing when I commit that I'm not,
>> I'll be happy to change my scripts.  My $LANG is set to en_US.UTF-8
>> which should DTRT to the best of my knowledge, but clearly, that isn't
>> the case.

No, LC_CTYPE defines what charset you use. (I may be wrong, though.)


	-`J'
-- 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: OT: character encodings (was: Linux 2.6.20-rc4)
  2007-01-07 20:40                   ` Jan Engelhardt
@ 2007-01-07 21:07                     ` Xavier Bestel
  0 siblings, 0 replies; 4+ messages in thread
From: Xavier Bestel @ 2007-01-07 21:07 UTC (permalink / raw)
  To: Jan Engelhardt
  Cc: Sean, Dave Jones, Alan, David Woodhouse, Tilman Schmidt,
	Linux Kernel Mailing List, git

Le dimanche 07 janvier 2007 à 21:40 +0100, Jan Engelhardt a écrit :
> >On Sun, 7 Jan 2007 15:05:53 -0500
> >Dave Jones <davej@redhat.com> wrote:
> >
> >> If there's something I should be doing when I commit that I'm not,
> >> I'll be happy to change my scripts.  My $LANG is set to en_US.UTF-8
> >> which should DTRT to the best of my knowledge, but clearly, that isn't
> >> the case.
> 
> No, LC_CTYPE defines what charset you use. (I may be wrong, though.)

IIRC LANG is a superset for all LC_* - i.e. if only LANG is defined, it
sets all your locales, but you can individually set the charset, numeric
format, date format, etc.

	Xav

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: OT: character encodings
       [not found]                   ` <45A17645.1030905@imap.cc>
@ 2007-01-08  1:53                     ` David Woodhouse
  0 siblings, 0 replies; 4+ messages in thread
From: David Woodhouse @ 2007-01-08  1:53 UTC (permalink / raw)
  To: Tilman Schmidt; +Cc: Russell King, git

On Sun, 2007-01-07 at 23:37 +0100, Tilman Schmidt wrote:
> > That depends on your point of view.  David's assertion was that git
> > internally uses UTF-8.
> 
> Well, I'm inclined to say he was wrong. Git internally is completely
> oblivious to character encoding.

See the 'i18n.commitencoding' property, stored in the repository config
and defaulting to UTF-8. Git is certainly capable of converting to its
internal storage encoding when you commit; if it doesn't do so by
default then that would be a bug.

-- 
dwmw2

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-01-08  1:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <Pine.LNX.4.64.0701062216210.3661@woody.osdl.org>
     [not found] ` <Pine.LNX.4.61.0701071152570.4365@yvahk01.tjqt.qr>
     [not found]   ` <20070107114439.GC21613@flint.arm.linux.org.uk>
     [not found]     ` <45A0F060.9090207@imap.cc>
     [not found]       ` <1168182838.14763.24.camel@shinybook.infradead.org>
     [not found]         ` <20070107153833.GA21133@flint.arm.linux.org.uk>
     [not found]           ` <20070107182151.7cc544f3@localhost.localdomain>
     [not found]             ` <20070107191730.GD21133@flint.arm.linux.org.uk>
     [not found]               ` <20070107200553.GA15101@redhat.com>
2007-01-07 20:15                 ` OT: character encodings (was: Linux 2.6.20-rc4) Sean
2007-01-07 20:40                   ` Jan Engelhardt
2007-01-07 21:07                     ` Xavier Bestel
     [not found]           ` <1168187346.14763.70.camel@shinybook.infradead.org>
     [not found]             ` <20070107170656.GC21133@flint.arm.linux.org.uk>
     [not found]               ` <45A14A2A.9060306@imap.cc>
     [not found]                 ` <20070107195051.GF21133@flint.arm.linux.org.uk>
     [not found]                   ` <45A17645.1030905@imap.cc>
2007-01-08  1:53                     ` OT: character encodings David Woodhouse

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).