git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] git-revert: Fix die before git-sh-setup defines it.
@ 2007-01-12  6:45 Bob Proulx
  0 siblings, 0 replies; only message in thread
From: Bob Proulx @ 2007-01-12  6:45 UTC (permalink / raw)
  To: git

The code previously checked it's own name and called 'die' upon
an error.  However 'die' was not yet defined because git-sh-setup
had not been sourced yet.  Instead simply write the error message
to stderr and exit with an error as was originally desired.

Signed-off-by: Bob Proulx <bob@proulx.com>
---

I found this by inspection.  I contemplated several different ways of
resolving it but in the end the simplest seemed to be the best.

 git-revert.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-revert.sh b/git-revert.sh
index 50cc47b..5ca894a 100755
--- a/git-revert.sh
+++ b/git-revert.sh
@@ -16,7 +16,7 @@ case "$0" in
 	me=cherry-pick
 	USAGE='[--edit] [-n] [-r] [-x] <commit-ish>'  ;;
 * )
-	die "What are you talking about?" ;;
+	echo "What are you talking about?" 1>&2 ; exit 1 ;;
 esac
 . git-sh-setup
 
-- 
1.4.0

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-01-12  7:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-12  6:45 [PATCH] git-revert: Fix die before git-sh-setup defines it Bob Proulx

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).