From: Josef Weidendorfer <Josef.Weidendorfer@gmx.de>
To: Junio C Hamano <junkio@cox.net>
Cc: Andy Parkins <andyparkins@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] Allow whole-tree operations to be started from a subdirectory
Date: Sun, 14 Jan 2007 01:11:20 +0100 [thread overview]
Message-ID: <200701140111.20671.Josef.Weidendorfer@gmx.de> (raw)
In-Reply-To: <7vac0orml9.fsf_-_@assigned-by-dhcp.cox.net>
On Friday 12 January 2007 21:56, Junio C Hamano wrote:
> This updates five commands (merge, pull, rebase, revert and cherry-pick)
> so that they can be started from a subdirectory.
>
> This may not actually be what we want to do. These commands are
> inherently whole-tree operations, and an inexperienced user may
> mistakenly expect a "git pull" from a subdirectory would merge
> only the subdirectory the command started from.
Yes, this IMHO is a problem.
Why not add a general "--top" option to the "git" wrapper,
to temporarily let git change to the toplevel while running
the command?
The wish to allow git-fetch from subdirectories is the
inconvenience to have to cd up, and later down. This is
avoided by running "git --top fetch", and theses people
should be happy.
Yet, if the command outputs some relative paths, the
user is very well aware that these paths are from the
toplevel, as he explicitly specified "--top".
Aside from this, the "--top" options sometimes could
be handy even for other git commands.
And when e.g. git fetch is run from a subdirectory, we
could add to the (now better) error message:
You need to run this command from the toplevel of the working tree.
Alternatively, run "git --top ..." to temporary switch to the
toplevel while running the git command.
Josef
next prev parent reply other threads:[~2007-01-14 0:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-12 2:43 What's in git.git and announcing GIT v1.5.0-rc1 Junio C Hamano
2007-01-12 3:59 ` [PATCH] reflog-expire: brown paper bag fix Junio C Hamano
2007-01-12 4:02 ` Shawn O. Pearce
2007-01-12 15:01 ` What's in git.git and announcing GIT v1.5.0-rc1 Andy Parkins
2007-01-12 18:35 ` [PATCH] Friendlier error message for commands that can't be run from a subdirectory koreth
2007-01-12 18:39 ` What's in git.git and announcing GIT v1.5.0-rc1 Steven Grimm
2007-01-12 19:10 ` [PATCH] Change to the repository's root directory if needed koreth
2007-01-12 21:18 ` Junio C Hamano
2007-01-12 22:11 ` Steven Grimm
2007-01-12 23:17 ` Junio C Hamano
2007-01-12 20:26 ` [PATCH] Explain "Not a git repository: '.git'" Junio C Hamano
2007-01-12 20:55 ` Junio C Hamano
2007-01-12 20:55 ` [PATCH 1/3] Define cd_to_toplevel shell function in git-sh-setup Junio C Hamano
2007-01-12 20:55 ` [PATCH 2/3] Use cd_to_toplevel in scripts that implement it by hand Junio C Hamano
2007-01-12 20:56 ` [PATCH 3/3] Allow whole-tree operations to be started from a subdirectory Junio C Hamano
2007-01-13 16:42 ` Andy Parkins
2007-01-14 0:11 ` Josef Weidendorfer [this message]
2007-01-14 0:21 ` Shawn O. Pearce
2007-01-14 0:39 ` Josef Weidendorfer
2007-01-14 0:50 ` Junio C Hamano
2007-01-14 0:52 ` Steven Grimm
2007-01-14 1:37 ` Junio C Hamano
2007-01-14 18:13 ` Steven Grimm
2007-01-14 18:29 ` Steven Grimm
2007-01-14 19:36 ` Junio C Hamano
2007-01-14 1:50 ` Junio C Hamano
2007-01-16 15:14 ` Andreas Ericsson
2007-01-14 23:36 ` What's in git.git and announcing GIT v1.5.0-rc1 lamikr
2007-01-15 2:21 ` Horst H. von Brand
2007-01-15 20:54 ` lamikr
2007-01-15 21:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701140111.20671.Josef.Weidendorfer@gmx.de \
--to=josef.weidendorfer@gmx.de \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).