From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH 2/4] Hash tags by commit SHA1 in git-describe.
Date: Sun, 14 Jan 2007 18:19:37 -0500 [thread overview]
Message-ID: <20070114231937.GF10888@spearce.org> (raw)
In-Reply-To: <7vr6txh278.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > On Sat, 13 Jan 2007, Shawn O. Pearce wrote:
> >
> >> If a project has a very large number of tags then git-describe
> >> will spend a good part of its time looping over the tags testing
> >> them one at a time to determine if it matches a given commit.
> >
> > Why not just use object_refs? This also obviates the need for your patch
> > 3/4, since you no longer have buckets to search binarily. Plus, it uses a
> > hash map, which already turned out to beat (in terms of performance) the
> > hell out of bucketed lists in git history.
>
> Very good point.
OK. I didn't realize we had a better system already implemented.
Thanks for pointing it out.
I'll work up a patch to replace the crude hash/list arrangement
with something based on object_refs instead.
--
Shawn.
next prev parent reply other threads:[~2007-01-15 17:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8e29bab8b4b9f53cbdc85e6e783bf3b5d3787f0f.1168727248.git.spearce@spearce.org>
2007-01-13 22:28 ` [PATCH 2/4] Hash tags by commit SHA1 in git-describe Shawn O. Pearce
2007-01-14 13:01 ` Johannes Schindelin
2007-01-14 18:51 ` Junio C Hamano
2007-01-14 23:19 ` Shawn O. Pearce [this message]
2007-01-13 22:29 ` [PATCH 3/4] Use binary searching on large buckets " Shawn O. Pearce
2007-01-14 19:11 ` Junio C Hamano
2007-01-14 23:07 ` Shawn O. Pearce
2007-01-13 22:30 ` [PATCH 4/4] Improve git-describe performance by reducing revision listing Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070114231937.GF10888@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).