From: "Shawn O. Pearce" <spearce@spearce.org>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Junio C Hamano <junkio@cox.net>, Josh Boyer <jwboyer@gmail.com>,
git@vger.kernel.org, davidk@lysator.liu.se
Subject: Re: [PATCH/POLL] git-format-patch: the default suffix is now .patch, not .txt
Date: Thu, 18 Jan 2007 03:06:13 -0500 [thread overview]
Message-ID: <20070118080613.GE23124@spearce.org> (raw)
In-Reply-To: <81b0412b0701172359y1ef4f936pcdcb2de53d6bd468@mail.gmail.com>
Alex Riesen <raa.lkml@gmail.com> wrote:
> Also, how many mail clients know that .patch is actually
> a text and not application/binary? It'll make patch
> reviewing harder for some (not sure if I'd like a review
> of such a person, though).
Patches intended for review should be sent inline, not attached.
Thus the file extension has no impact on how the mail client should
treat it.
Don't count people out just because they cannot read a *.patch file
All constructive feedback is valuable, no matter its source. Of
course I did qualify that with "constructive"... ;-)
--
Shawn.
next prev parent reply other threads:[~2007-01-18 8:06 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-17 13:10 [RFC] Add a suffix option to git-format-patch Josh Boyer
2007-01-17 13:49 ` Johannes Schindelin
2007-01-17 14:50 ` Josh Boyer
2007-01-17 16:39 ` Horst H. von Brand
2007-01-17 19:18 ` [PATCH] Introduce 'git-format-patch --suffix=patch' Junio C Hamano
2007-01-17 19:20 ` Andy Whitcroft
2007-01-17 19:27 ` Junio C Hamano
2007-01-17 19:51 ` Brian Gernhardt
2007-01-17 19:57 ` Junio C Hamano
2007-01-17 20:08 ` Brian Gernhardt
2007-01-17 20:22 ` [PATCH] Make format-patch --suffix="" not add any suffix Brian Gernhardt
2007-01-18 1:11 ` [PATCH] Introduce 'git-format-patch --suffix=patch' Johannes Schindelin
2007-01-17 15:43 ` [RFC] Add a suffix option to git-format-patch David Kågedal
2007-01-17 16:57 ` Andreas Ericsson
2007-01-17 17:05 ` Johannes Schindelin
2007-01-17 17:33 ` Junio C Hamano
2007-01-17 18:15 ` David Kågedal
2007-01-17 20:18 ` Josh Boyer
2007-01-17 20:20 ` Josh Boyer
[not found] ` <7vsle9p8pg.fsf@assigned-by-dhcp.cox.net>
2007-01-18 0:06 ` [PATCH/POLL] git-format-patch: the default suffix is now .patch, not .txt Junio C Hamano
2007-01-18 1:06 ` Johannes Schindelin
2007-01-18 7:59 ` Alex Riesen
2007-01-18 8:06 ` Shawn O. Pearce [this message]
2007-01-18 8:18 ` Alex Riesen
2007-01-18 9:10 ` Junio C Hamano
2007-01-18 9:21 ` Alex Riesen
2007-01-18 8:43 ` Junio C Hamano
2007-01-18 9:35 ` Alex Riesen
2007-01-18 11:52 ` Josh Boyer
2007-01-18 13:33 ` Johannes Schindelin
2007-01-18 13:46 ` Alex Riesen
2007-01-18 13:40 ` Alex Riesen
2007-01-18 14:10 ` Andreas Ericsson
2007-01-18 14:15 ` Johannes Schindelin
2007-01-18 14:41 ` Alex Riesen
2007-01-18 14:49 ` Johannes Schindelin
2007-01-18 14:53 ` Alex Riesen
2007-01-18 15:16 ` Johannes Schindelin
2007-01-18 15:37 ` Alex Riesen
2007-01-18 15:42 ` Josh Boyer
2007-01-18 20:03 ` Johannes Schindelin
2007-01-18 20:12 ` Josh Boyer
2007-01-18 15:26 ` Shawn O. Pearce
2007-01-18 15:52 ` Alex Riesen
2007-01-18 19:29 ` Steven Grimm
2007-01-18 19:57 ` Johannes Schindelin
2007-01-18 16:09 ` Johannes Sixt
2007-01-19 10:11 ` Jakub Narebski
2007-01-18 15:42 ` Shawn O. Pearce
2007-01-18 16:05 ` Alex Riesen
2007-01-18 16:29 ` Andreas Ericsson
2007-01-18 16:51 ` Shawn O. Pearce
2007-01-18 17:03 ` Andreas Ericsson
2007-01-18 19:30 ` Martin Langhoff
2007-01-18 19:19 ` Martin Langhoff
2007-01-18 12:40 ` Andreas Ericsson
2007-01-18 15:10 ` Lukas Sandström
2007-01-18 15:29 ` Brian Gernhardt
2007-01-18 9:57 ` Alexandre Julliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070118080613.GE23124@spearce.org \
--to=spearce@spearce.org \
--cc=davidk@lysator.liu.se \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=jwboyer@gmail.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).