git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Andreas Ericsson <ae@op5.se>
Cc: Jim Treadway <jim@stardot-tech.com>,
	Junio C Hamano <junkio@cox.net>,
	git@vger.kernel.org
Subject: Re: [PATCH 1/2] Document the master@{n} reflog query syntax.
Date: Thu, 18 Jan 2007 10:48:45 -0500	[thread overview]
Message-ID: <20070118154845.GD15428@spearce.org> (raw)
In-Reply-To: <45AF4CDF.5010406@op5.se>

Andreas Ericsson <ae@op5.se> wrote:
> Shawn O. Pearce wrote:
> >Jim Treadway <jim@stardot-tech.com> wrote:
> >>On Wed, 17 Jan 2007, Shawn O. Pearce wrote:
> >>>-  of the ref at a prior point in time.  This suffix may only be
> >>>+  of the ref at a prior point in time.This suffix may only be
> >>I'm guessing that the above was unintentional?
> >
> >Yes.  Danngit.  Junio, can you hand edit that patch?
> >
> 
> I'm starting to see --amend as an extremely useful thing to have, and 
> I'm sure Junio thinks the same. For fixes this small, it sure is easier 
> to just --amend the commit than to ask for a new patch to apply.

I still shouldn't have let that change sneak into the diff.  I know
how it happened, I wanted to copy part of that line so I wiggled
it around in vi, copied it, then hit undo.  I didn't undo back far
enough.  Then I didn't read the diff closely enough before sending.

> Out of curiousity, how many other SCM's allow you to --amend a commit?

None that I know of.

-- 
Shawn.

      reply	other threads:[~2007-01-18 15:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-18  2:08 [PATCH 1/2] Document the master@{n} reflog query syntax Shawn O. Pearce
2007-01-18  2:30 ` Jim Treadway
2007-01-18  2:50   ` Shawn O. Pearce
2007-01-18 10:33     ` Andreas Ericsson
2007-01-18 15:48       ` Shawn O. Pearce [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070118154845.GD15428@spearce.org \
    --to=spearce@spearce.org \
    --cc=ae@op5.se \
    --cc=git@vger.kernel.org \
    --cc=jim@stardot-tech.com \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).