From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH] New files in git weren't being downloaded during CVS update
Date: Fri, 19 Jan 2007 10:49:40 +0000 [thread overview]
Message-ID: <200701191049.40833.andyparkins@gmail.com> (raw)
If a repository was checked out via git-cvsserver and then later a new
file is added to the git repository via some other method; a CVS update
wasn't fetching the new file.
It would be reported as a new file as
A some/dir/newfile.c
but would never appear in the directory.
The problem (I think) is that when git-cvsserver detected a new file, it
was issuing the new file message then skipping the actual file send part
and moving to the next file its list. In fact only an updated file
would be transmitted.
The fix is to simply remove the "next" that was skipping the file
transmit; which is what this patch does.
Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
I don't understand enough about the CVS protocol to know whether this really
is the right fix. It certainly addresses my problem, but I assume that the "next"
was put in there for a reason.
git-cvsserver.perl | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index a33a876..c370a53 100755
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -882,7 +882,6 @@ sub req_update
print "MT text A \n";
print "MT fname $filename\n";
print "MT newline\n";
- next;
}
else {
--
1.5.0.rc1.gf4b6c
next reply other threads:[~2007-01-19 22:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-19 10:49 Andy Parkins [this message]
2007-01-20 1:19 ` [PATCH] New files in git weren't being downloaded during CVS update Simon 'corecode' Schubert
2007-01-20 10:25 ` Andy Parkins
2007-01-20 10:41 ` Simon 'corecode' Schubert
-- strict thread matches above, loose matches on Subject: below --
2007-01-21 14:25 Andy Parkins
2007-01-22 2:35 ` Junio C Hamano
2007-01-22 7:02 ` Martin Langhoff
2007-01-22 7:16 ` Junio C Hamano
2007-01-22 10:44 ` Andy Parkins
2007-01-22 10:46 ` Andy Parkins
2007-01-22 10:56 ` Andy Parkins
2007-01-22 11:08 ` Simon 'corecode' Schubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701191049.40833.andyparkins@gmail.com \
--to=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).