From: "Shawn O. Pearce" <spearce@spearce.org>
To: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
Cc: Peter Eriksen <s022018@student.dtu.dk>, git@vger.kernel.org
Subject: Re: [PATCH] sha1_file.c: Avoid multiple calls to find_pack_entry().
Date: Mon, 22 Jan 2007 16:07:19 -0500 [thread overview]
Message-ID: <20070122210719.GA29975@spearce.org> (raw)
In-Reply-To: <45B524E1.5060205@fs.ei.tum.de>
Simon 'corecode' Schubert <corecode@fs.ei.tum.de> wrote:
> Peter Eriksen wrote:
> >We used to call find_pack_entry() twice from read_sha1_file() in order
> >to avoid printing an error message, when the object did not exist. This
> >is fixed by moving the call to error() to the only place it really
> >could be called.
> >
> >Signed-off-by: Peter Eriksen <s022018@student.dtu.dk>
>
> I noticed this originally, Peter was so kind to come up with a patch.
> Reviewed and found +1, so:
>
> Signed-off-by: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
Wow. That's ugly. Thanks for finding and patching it.
--
Shawn.
next prev parent reply other threads:[~2007-01-22 21:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-22 20:29 [PATCH] sha1_file.c: Avoid multiple calls to find_pack_entry() Peter Eriksen
2007-01-22 20:56 ` Simon 'corecode' Schubert
2007-01-22 21:07 ` Shawn O. Pearce [this message]
2007-01-23 0:25 ` Linus Torvalds
2007-01-23 0:39 ` Jakub Narebski
2007-01-23 2:10 ` Morten Welinder
2007-01-23 3:17 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070122210719.GA29975@spearce.org \
--to=spearce@spearce.org \
--cc=corecode@fs.ei.tum.de \
--cc=git@vger.kernel.org \
--cc=s022018@student.dtu.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).