* [PATCH 2/2] Remove unnecessary found variable from describe.
[not found] <2d9c5cd428a8962a64628a4e429263576bc46762.1169746766.git.spearce@spearce.org>
@ 2007-01-25 17:40 ` Shawn O. Pearce
0 siblings, 0 replies; only message in thread
From: Shawn O. Pearce @ 2007-01-25 17:40 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Junio added the found variable to enforce commit date order when two
tags have the same distance from the requested commit. Except it is
unnecessary as match_cnt is already used to record how many possible
tags have been identified thus far.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
builtin-describe.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/builtin-describe.c b/builtin-describe.c
index d8ff621..14c712a 100644
--- a/builtin-describe.c
+++ b/builtin-describe.c
@@ -101,7 +101,6 @@ static void describe(const char *arg, int last_one)
struct possible_tag all_matches[MAX_TAGS];
unsigned int match_cnt = 0, annotated_cnt = 0, cur_match;
unsigned long seen_commits = 0;
- int found = 0;
if (get_sha1(arg, sha1))
die("Not a valid object name %s", arg);
@@ -137,7 +136,7 @@ static void describe(const char *arg, int last_one)
t->name = n;
t->depth = seen_commits - 1;
t->flag_within = 1u << match_cnt;
- t->found_order = found++;
+ t->found_order = match_cnt;
c->object.flags |= t->flag_within;
if (n->prio == 2)
annotated_cnt++;
--
1.5.0.rc2.g18af
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-01-25 17:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <2d9c5cd428a8962a64628a4e429263576bc46762.1169746766.git.spearce@spearce.org>
2007-01-25 17:40 ` [PATCH 2/2] Remove unnecessary found variable from describe Shawn O. Pearce
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).