From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Teach git-describe to display distances from tags.
Date: Thu, 25 Jan 2007 16:49:23 -0500 [thread overview]
Message-ID: <20070125214923.GD13874@spearce.org> (raw)
In-Reply-To: <7v7ivaailb.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> - We need to update the documentation to say what this new
> number means.
Indeed; I apologize for forgetting to do that. At this point
I'll wind up resending the patch to address everything so toss
what you have.
> It's some number close to the number of revs since the named
> tag, but not exactly.
>
> $ git describe --debug 65ebe634 2>&1 | head -4
> searching to describe 65ebe634
> annotated 251 v2.6.20-rc5
> annotated 427 v2.6.20-rc4
> annotated 594 v2.6.20-rc3
> $ git rev-list v2.6.20-rc5..65ebe634 | wc -l
> 254
> $ git rev-list v2.6.20-rc4..65ebe634 | wc -l
> 430
>
> And it does not seem to be always "minus 3" either.
What you skipped in the --debug output above was that we hit
our internal possible tag limit (10 by default) and aborted
walking the revision chain. That's why we missed 3 revs in
our counting. :)
We probably should make an option to enable the count, and
if the count is enabled then we'll have to pickup counting
where we left off and finish it out for the chosen tag so
the count is correct.
--
Shawn.
next prev parent reply other threads:[~2007-01-25 21:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 17:39 [PATCH 1/2] Teach git-describe to display distances from tags Shawn O. Pearce
2007-01-25 21:26 ` Junio C Hamano
2007-01-25 21:37 ` Shawn O. Pearce
2007-01-25 21:42 ` Junio C Hamano
2007-01-25 21:49 ` Shawn O. Pearce [this message]
2007-01-25 23:32 ` Nicolas Pitre
2007-01-26 0:13 ` Junio C Hamano
2007-01-26 8:52 ` Francis Moreau
2007-01-26 9:00 ` Junio C Hamano
2007-01-26 9:39 ` Francis Moreau
2007-01-26 9:51 ` Shawn O. Pearce
2007-01-26 10:36 ` Andy Parkins
2007-01-26 14:28 ` [PATCH] If abbrev is set to zero in git-describe, don't add the unique suffix Andy Parkins
2007-01-26 13:33 ` [PATCH 1/2] Teach git-describe to display distances from tags Jakub Narebski
2007-01-26 19:37 ` Matthias Lederhofer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070125214923.GD13874@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).