git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] Replace perl code with pure shell code
Date: Mon, 29 Jan 2007 04:28:16 -0500	[thread overview]
Message-ID: <20070129092815.GA22486@spearce.org> (raw)
In-Reply-To: <45BDBBCA.6030107@fs.ei.tum.de>

Simon 'corecode' Schubert <corecode@fs.ei.tum.de> wrote:
> I already wondered.  What's those ^{} tags, and why is CLONE_HEAD littered 
> with them?

They are the deref of the thing without them.

As in, "foo" is a tag pointing at some object (probably a commit
but not necessarily) then "foo^{}" is whatever "foo"'s tag points at.
 
> +		case "$name" in
> +		*^{*)
> +			continue ;;

Probably could just be:

		case "$name" in
		*^{})
			continue ;;

This is common in Git.  ^{} on the end of a ref name shows up in
the peek-remote/ls-remote output, but certainly is *not* a ref.

Sorry I missed that case eariler when I reviewed the patch. I thought
about it and why it wasn't handled here, but then thought maybe it
wasn't actually occuring in the input (that someone else higher up
had filtered them out).

-- 
Shawn.

  reply	other threads:[~2007-01-29  9:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-29  8:09 [PATCH] Replace perl code with pure shell code Simon 'corecode' Schubert
2007-01-29  8:56 ` Junio C Hamano
2007-01-29  9:18   ` Simon 'corecode' Schubert
2007-01-29  9:28     ` Shawn O. Pearce [this message]
2007-01-29 11:41 ` Randal L. Schwartz
2007-01-29 12:38   ` Nikolai Weibull
2007-01-29 12:53     ` Randal L. Schwartz
2007-01-29 13:17       ` Nikolai Weibull
2007-01-29 13:21         ` Randal L. Schwartz
2007-01-30 10:57       ` Junio C Hamano
2007-01-29 12:43   ` Jakub Narebski
2007-01-29 12:54     ` Randal L. Schwartz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070129092815.GA22486@spearce.org \
    --to=spearce@spearce.org \
    --cc=corecode@fs.ei.tum.de \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).