git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Cc: "Marco Costalba" <mcostalba@gmail.com>
Subject: Re: [PATCH] qgit: Default the log window to wider than the file list and set monospaced font
Date: Thu, 8 Feb 2007 10:20:41 +0000	[thread overview]
Message-ID: <200702081020.44202.andyparkins@gmail.com> (raw)
In-Reply-To: <e5bfff550702080039l236b1f69o6765b8e2dff3e3c4@mail.gmail.com>

On Thursday 2007 February 08 08:39, Marco Costalba wrote:

> Regarding "Monospace" it should be changeable with Settings menu and
> should apply _only_ to fixed space font viewers, in our case only
> patch viewer and file content viewer.

The log message was the one I changed.  Having the log message in variable 
width breaks any ascii-art in the message.

I completely agree about pulling the setting from the config.  I'll see if I 
can find that and post a further patch.

> If you see Monospace applied to list view or any other widget apart
> from the above mentioned ones then it's a bug.

True.  I used "Monospaced" as the font as that defaults to the system-wide 
monospaced font; however it's pretty poor form.  I raise my hand - shoot 
me :-)  As I say, I'll try and do better and send a new patch.


Andy
-- 
Dr Andy Parkins, M Eng (hons), MIEE
andyparkins@gmail.com

  parent reply	other threads:[~2007-02-08 10:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-07 21:38 [PATCH] qgit: Default the log window to wider than the file list and set monospaced font Andy Parkins
2007-02-08  8:39 ` Marco Costalba
2007-02-08  9:46   ` Jakub Narebski
2007-02-08 10:20   ` Andy Parkins [this message]
2007-02-08 19:06     ` Marco Costalba
2007-02-08 19:12       ` Andy Parkins
2007-02-08 19:29         ` Marco Costalba
2007-02-08 19:51           ` Marco Costalba
2007-02-08 21:58             ` Andy Parkins
2007-02-08 23:31               ` [PATCH] qgit4: Add a header and set the font family appropriately to the log message Andy Parkins
2007-02-08 23:41                 ` Shawn O. Pearce
2007-02-08 23:58                   ` Junio C Hamano
2007-02-09  0:29                     ` Linus Torvalds
2007-02-09  0:43                       ` [PATCH] format-patch -n: make sorting easier by padding number Johannes Schindelin
2007-02-09  0:47                         ` Johannes Schindelin
2007-02-09  9:19                     ` [PATCH] qgit4: Add a header and set the font family appropriately to the log message Michael S. Tsirkin
2007-02-09  5:44                 ` Marco Costalba
2007-02-08 23:31               ` [PATCH] qgit4: Removed the monospace font override from the log viewer box Andy Parkins
2007-02-08 23:31               ` [PATCH] qgit4: Set a 5:1 stretch ratio on the left and right halves of the patch viewer Andy Parkins
2007-02-08 23:04           ` [PATCH] qgit: Default the log window to wider than the file list and set monospaced font Andy Parkins
2007-02-08 10:22   ` Andy Parkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702081020.44202.andyparkins@gmail.com \
    --to=andyparkins@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=mcostalba@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).