From: Eric Wong <normalperson@yhbt.net>
To: Michael Spang <mcspang@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git-svn test suite failures due to Subversion race
Date: Mon, 12 Feb 2007 19:21:37 -0800 [thread overview]
Message-ID: <20070213032137.GA28534@localdomain> (raw)
In-Reply-To: <45D1239C.4040706@gmail.com>
Michael Spang <mcspang@gmail.com> wrote:
> I've prepared a somewhat cleaner patch that solves the problem without
> using sleep. It increases the modification time by one second
> immediately prior to each commit. I added calls everywhere I think the
> problem could potentially occur.
>
> I've had no failures with the patch (without it, they are quite frequent).
Thanks for the patch. Just one portability nit below, otherwise:
Acked-by: Eric Wong <normalperson@yhbt.net>
> +poke() {
> + touch -r "$1" -d +1sec "$1"
> +}
I'm not sure that -d is portable. However,
perl -e '@x = stat($ARGV[0]); utime($x[8], $x[9] + 1, $ARGV[0])' "$1"
should work on any platform git-svn runs on.
--
Eric Wong
next prev parent reply other threads:[~2007-02-13 3:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 3:32 git-svn test suite failures due to Subversion race Michael Spang
2007-02-12 10:38 ` Eric Wong
2007-02-13 2:34 ` Michael Spang
2007-02-13 3:03 ` Junio C Hamano
2007-02-13 3:21 ` Eric Wong [this message]
2007-02-13 6:17 ` Junio C Hamano
2007-02-14 1:35 ` Michael Spang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070213032137.GA28534@localdomain \
--to=normalperson@yhbt.net \
--cc=git@vger.kernel.org \
--cc=mcspang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).