* [PATCH] git-gui: fix typo in GIT-VERSION-GEN, "/dev/null" not "/devnull"
@ 2007-02-13 15:26 Andy Parkins
2007-02-13 15:32 ` Shawn O. Pearce
0 siblings, 1 reply; 2+ messages in thread
From: Andy Parkins @ 2007-02-13 15:26 UTC (permalink / raw)
To: git
Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
I think this would make git-gui get the wrong version number as the script
wouldn't complete successfully.
git-gui/GIT-VERSION-GEN | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-gui/GIT-VERSION-GEN b/git-gui/GIT-VERSION-GEN
index 8fac8cb..9966126 100755
--- a/git-gui/GIT-VERSION-GEN
+++ b/git-gui/GIT-VERSION-GEN
@@ -10,7 +10,7 @@ tree_search ()
{
head=$1
tree=$2
- for p in $(git rev-list --parents --max-count=1 $head 2>/devnull)
+ for p in $(git rev-list --parents --max-count=1 $head 2>/dev/null)
do
test $tree = $(git rev-parse $p^{tree} 2>/dev/null) &&
vn=$(git describe --abbrev=4 $p 2>/dev/null) &&
--
1.5.0.rc4.365.g5eff6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] git-gui: fix typo in GIT-VERSION-GEN, "/dev/null" not "/devnull"
2007-02-13 15:26 [PATCH] git-gui: fix typo in GIT-VERSION-GEN, "/dev/null" not "/devnull" Andy Parkins
@ 2007-02-13 15:32 ` Shawn O. Pearce
0 siblings, 0 replies; 2+ messages in thread
From: Shawn O. Pearce @ 2007-02-13 15:32 UTC (permalink / raw)
To: Andy Parkins; +Cc: git
Andy Parkins <andyparkins@gmail.com> wrote:
> - for p in $(git rev-list --parents --max-count=1 $head 2>/devnull)
> + for p in $(git rev-list --parents --max-count=1 $head 2>/dev/null)
[git (sp/gitgui)]$ ls /devnull
/devnull
Gaaaaah. Damn Mac. Thanks for the patch, I'm applying it now.
--
Shawn.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-13 15:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-13 15:26 [PATCH] git-gui: fix typo in GIT-VERSION-GEN, "/dev/null" not "/devnull" Andy Parkins
2007-02-13 15:32 ` Shawn O. Pearce
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).