git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Lederhofer <matled@gmx.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] pager: use an environment variable for pager_in_use
Date: Fri, 16 Feb 2007 19:56:53 +0100	[thread overview]
Message-ID: <20070216185653.GA10308@moooo.ath.cx> (raw)
In-Reply-To: <Pine.LNX.4.63.0702161934230.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> +int pager_in_use = getenv("GIT_PAGER_IN_USE");
test.c:3: error: initializer element is not constant

So you could only add this at another place where pager_in_use is not yet
used (e.g. start of main or some other initialization method).
I did not want to put it at the beginning of main or another function.
After adding GIT_PAGER_IN_USE I thought it would make sense to remove
pager_in_use because there were only two parts of code using
pager_in_use:
> pager_in_use = 1;
> setenv(..);
and
> pager_in_use || getenv(..)

  reply	other threads:[~2007-02-16 18:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-16 15:19 [BUG] git -p status does not use colors Matthias Lederhofer
2007-02-16 15:56 ` Jeff King
2007-02-16 18:22   ` [PATCH] pager: use an environment variable for pager_in_use Matthias Lederhofer
2007-02-16 18:35     ` Johannes Schindelin
2007-02-16 18:56       ` Matthias Lederhofer [this message]
2007-02-16 19:06         ` Johannes Schindelin
2007-02-16 19:43           ` Simon 'corecode' Schubert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070216185653.GA10308@moooo.ath.cx \
    --to=matled@gmx.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).