git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Martin Waitz <tali@admingilde.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Support for large files on 32bit systems.
Date: Sat, 17 Feb 2007 04:49:59 -0500	[thread overview]
Message-ID: <20070217094959.GH27864@spearce.org> (raw)
In-Reply-To: <20070217093953.GE21842@admingilde.org>

Martin Waitz <tali@admingilde.org> wrote:
> arg, this patch is completely broken.
> I tested it by setting the macro via the command line and the
> = is still left in there.  And __GLIBC__ is not yet defined at this
> point.
> 
> However, we need to set _FILE_OFFSET_BITS for glibc somehow.
> What is the best way to do so?

I think the only way to do with this is to have the Makefile detect
if -D_FILE_OFFSET_BITS=64 is required to be added to CFLAGS based on
some rule (e.g. uname output?), then add that to CFLAGS when needed.

This is one area where autoconf is nice, as you can compile
a thousand little C programs to see how the compiler reacts by
default, and when you attempt to set this define, and then decide
if you should include it or not.

It is also the part of autoconf that's not-so-nice... as it compiles
a thousand little C programs just to figure out how to compile the
real program.  ;-)

-- 
Shawn.

  reply	other threads:[~2007-02-17  9:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-17  9:13 [PATCH] Support for large files on 32bit systems Martin Waitz
2007-02-17  9:39 ` Martin Waitz
2007-02-17  9:49   ` Shawn O. Pearce [this message]
2007-02-17 10:46     ` Martin Waitz
2007-02-17 13:32     ` Nicolas Pitre
2007-02-19  2:44       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070217094959.GH27864@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=tali@admingilde.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).