Re: [PATCH 1/3] Wrap the log text in some nice HTML to highlight the commit message

Re: [PATCH 1/3] Wrap the log text in some nice HTML to highlight the commit message

[Andy Parkins]

On Saturday 2007, February 17, Andy Parkins wrote:
> Signed-off-by: Andy Parkins <andyparkins@gmail.com>
> ---
> Hey Marco; I've finally got around to rebasing.  The problem I had
> was an error in my .git/config was making git-fetch just return
> without fetching so I wasn't getting your new master head.

Apologies all: this and following patches should have been marked qgit4; 
not mainline git.

Andy
-- 
Dr Andrew Parkins, M Eng (Hons), AMIEE
andyparkins@gmail.com

Re: [PATCH 1/3] Wrap the log text in some nice HTML to highlight the commit message

[Marco Costalba]

On 2/17/07, Andy Parkins <andyparkins@gmail.com> wrote:
> On Saturday 2007, February 17, Andy Parkins wrote:
> > Signed-off-by: Andy Parkins <andyparkins@gmail.com>
> > ---
> > Hey Marco; I've finally got around to rebasing.  The problem I had
> > was an error in my .git/config was making git-fetch just return
> > without fetching so I wasn't getting your new master head.
>
> Apologies all: this and following patches should have been marked qgit4;
> not mainline git.
>

Hi Andy,

thanks for your patches, but I can see only this email and the '[PATCH
2/3] Improve default column widths by changing resize modes', I miss
body of [PATCH 1/3]  and  [PATCH 3/3].

Please take a look at http://marc.theaimsgroup.com/?l=git&r=1&b=200702&w=2
to see what's landed on git list.

Marco

P.S: I will be on travel next week, so I won't be able to connect regularly.

Re: [PATCH 1/3] Wrap the log text in some nice HTML to highlight the commit message

[Andy Parkins]

On Sunday 2007, February 18, Marco Costalba wrote:

> thanks for your patches, but I can see only this email and the
> '[PATCH 2/3] Improve default column widths by changing resize modes',
> I miss body of [PATCH 1/3]  and  [PATCH 3/3].

I think that the mailing list spam filter is objecting because the email 
contains HTML tags.  I'll send the patches to you directly to bypass 
the spam filter.


Andy
-- 
Dr Andrew Parkins, M Eng (Hons), AMIEE
andyparkins@gmail.com

Re: [PATCH 1/3] Wrap the log text in some nice HTML to highlight the commit message

[Marco Costalba]

On 2/18/07, Andy Parkins <andyparkins@gmail.com> wrote:
> On Sunday 2007, February 18, Marco Costalba wrote:
>
> > thanks for your patches, but I can see only this email and the
> > '[PATCH 2/3] Improve default column widths by changing resize modes',
> > I miss body of [PATCH 1/3]  and  [PATCH 3/3].
>
> I think that the mailing list spam filter is objecting because the email
> contains HTML tags.  I'll send the patches to you directly to bypass
> the spam filter.
>
>

Hi Andy,

 I finally apply and pushed your patches to
git://repo.or.cz/qgit4.git, I have to say I really like your fancy
html log message.

Just a couple of notes:

- Font family is set to TYPE_WRITER_FONT, but font size is not taken
into account and seems fixed.

- There are some alignement issues in the header, sometimes author,
date, etc.. are left shifted without a clear reason wasting valuable
screen space.

Here are some snapshots to better clarify the points.

http://digilander.libero.it/mcostalba/andy1.png
http://digilander.libero.it/mcostalba/andy2.png
http://digilander.libero.it/mcostalba/andy3.png

Anyway a nice job.

Thanks
Marco

Re: [PATCH 1/3] Wrap the log text in some nice HTML to highlight the commit message

[Andy Parkins]

On Friday 2007 February 23 08:03, Marco Costalba wrote:
>  I finally apply and pushed your patches to
> git://repo.or.cz/qgit4.git, I have to say I really like your fancy
> html log message.

:-)  I'm glad you like it.  I was trying to make it look a bit like the email 
header in kmail.  I'm a bit disappointed with it aesthetically, but I do find 
it makes it a lot easier to view the separate log components without much 
brain power.

> - Font family is set to TYPE_WRITER_FONT, but font size is not taken
> into account and seems fixed.

Ah yes - probably a one-liner to fix.  I'll patch soon.

> - There are some alignement issues in the header, sometimes author,
> date, etc.. are left shifted without a clear reason wasting valuable
> screen space.

Yes you are certainly correct.  I'm going to point at Qt for the blame.  I 
have no idea why it's adding that space.  It goes away when the rowspan is 
removed from the short log part.  Additionally, Qt (despite the 
documentation) seems to ignore width=100% to table or divs, so I can't make 
the header actually look as nice as it could.

Once I figure out how to make it look better I'll certainly post patches, but 
at the moment it's a fight between me and Qt :-)  The solution, is going to 
be a compromise I think.  I might have to make the short log non-centered and 
non-rowspanning :-(

> Anyway a nice job.

Thanks.



Andy

-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com