From: "Shawn O. Pearce" <spearce@spearce.org>
To: Martin Waitz <tali@admingilde.org>
Cc: git@vger.kernel.org
Subject: Re: exception in git-gui when saving options
Date: Sun, 18 Feb 2007 02:14:58 -0500 [thread overview]
Message-ID: <20070218071457.GC31350@spearce.org> (raw)
In-Reply-To: <20070217194033.GH21842@admingilde.org>
Martin Waitz <tali@admingilde.org> wrote:
> I get the following backtrace when I want to save options in a
> git-gui which is started in blame mode:
>
> The options seem to be saved correctly.
Whoops. :-) Its fixed with the following commit in git-gui:
commit 372ef954a15c321a1065bf7e764449ce7767277f
Author: Shawn O. Pearce <spearce@spearce.org>
Date: Sun Feb 18 02:12:32 2007 -0500
git-gui: Correct crash when saving options in blame mode.
Martin Waitz noticed that git-gui crashed while saving the user's
options out if the application was started in blame mode. This
was caused by the do_save_config procedure invoking reshow_diff
incase the number of context lines was modified by the user.
Because we bypassed main window UI setup to enter blame mode we
did not set many of the globals which were accessed by reshow_diff,
and reading unset variables is an error in Tcl.
Aside from moving the globals to be set earlier, I also modified
reshow_diff to not invoke clear_diff if there is no path currently
in the diff viewer. This way reshow_diff does not crash when in
blame mode due to the $ui_diff command not being defined.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
--
Shawn.
prev parent reply other threads:[~2007-02-18 7:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-17 19:40 exception in git-gui when saving options Martin Waitz
2007-02-18 7:14 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070218071457.GC31350@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=tali@admingilde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).