git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH] Use git-update-ref to update a ref during commit in git-cvsserver
Date: Tue, 20 Feb 2007 20:10:01 +0000	[thread overview]
Message-ID: <200702202010.02128.andyparkins@gmail.com> (raw)
In-Reply-To: <200702200857.02779.andyparkins@gmail.com>

Nicholas Pitre mentioned that updating a reference should be done with
git-update-ref.

This patch does that and includes the -m option to have the reflog
updated as a bonus.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
As promised...

 git-cvsserver.perl |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index b4ef6bc..54d943a 100755
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -1216,9 +1216,9 @@ sub req_ci
     }
 
     close LOCKFILE;
-    my $reffile = "$ENV{GIT_DIR}refs/heads/$state->{module}";
-    unlink($reffile);
-    rename($lockfile, $reffile);
+    my $reffile = "refs/heads/$state->{module}";
+	`git-update-ref -m "git-cvsserver commit" $reffile $commithash $parenthash`;
+	unlink($lockfile);
     chdir "/";
 
     print "ok\n";
-- 
1.5.0.rc4.gb4d2

  reply	other threads:[~2007-02-20 20:13 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-20  7:28 Unresolved issues Junio C Hamano
     [not found] ` <Pine.LNX.4.64.07022009 34270.20368@woody.linux-foundation.org>
2007-02-20  8:57 ` Andy Parkins
2007-02-20 20:10   ` Andy Parkins [this message]
2007-02-20 21:57     ` [PATCH] Use git-update-ref to update a ref during commit in git-cvsserver Nicolas Pitre
2007-02-21  5:54     ` Junio C Hamano
2007-02-21  9:08       ` Andy Parkins
2007-02-27 12:48         ` [PATCH 1/2] Make 'cvs ci' lockless in git-cvsserver by using git-update-ref Andy Parkins
2007-02-27 13:55           ` Jakub Narebski
2007-02-27 14:35           ` Nicolas Pitre
2007-02-27 23:44           ` Junio C Hamano
2007-02-28  8:44             ` Andy Parkins
2007-02-28 18:06               ` Junio C Hamano
2007-02-27 12:49         ` [PATCH 2/2] cvsserver: Remove trailing "\n" from commithash in checkin function Andy Parkins
2007-02-27 23:45           ` Junio C Hamano
2007-02-28  8:45             ` Andy Parkins
2007-02-27 23:37       ` [PATCH] Use git-update-ref to update a ref during commit in git-cvsserver Martin Langhoff
2007-02-20 17:41 ` Unresolved issues Linus Torvalds
2007-02-20 21:43   ` Junio C Hamano
2007-02-21  0:21     ` Linus Torvalds
2007-02-21  0:25       ` Junio C Hamano
2007-02-21  0:39       ` Johannes Schindelin
2007-02-21  0:56         ` Linus Torvalds
2007-02-21  0:51           ` David Lang
2007-02-21  1:12           ` Johannes Schindelin
2007-02-21  1:51           ` Nicolas Pitre
2007-02-21  2:03             ` Linus Torvalds
2007-02-21 16:32           ` Robin Rosenberg
2007-02-21  1:49         ` Theodore Tso
2007-02-21 10:42         ` Martin Waitz
2007-02-21 12:55           ` Johannes Schindelin
2007-02-21 16:57             ` Brian Gernhardt
2007-02-21 17:05               ` Shawn O. Pearce
2007-02-22  8:28 ` [PATCH] git-status: do not be totally useless in a read-only repository Junio C Hamano
2007-02-22  8:30   ` [PATCH] update-index: do not die too early " Junio C Hamano
2007-02-26  1:33 ` Unresolved issues Julian Phillips
2007-02-26  3:39   ` Junio C Hamano
2007-02-26  5:10     ` Julian Phillips
2007-02-26  5:33       ` Junio C Hamano
2007-02-27 20:10   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702202010.02128.andyparkins@gmail.com \
    --to=andyparkins@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).