git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: git@vger.kernel.org
Subject: [PATCH] git-remote: support remotes with a dot in the name
Date: Wed, 21 Feb 2007 00:03:36 -0500	[thread overview]
Message-ID: <20070221050336.26431.46485.stgit@dv.roinet.com> (raw)

Ignore configuration data other that "url" and "fetch" for the remote. 
We cannot process it to extract the remote name from it reliably. 
Besides, a remote without "url" is currently invalid, so we are not
missing anything.

Signed-off-by: Pavel Roskin <proski@gnu.org>
---

 git-remote.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-remote.perl b/git-remote.perl
index 6e473ec..97b5f6c 100755
--- a/git-remote.perl
+++ b/git-remote.perl
@@ -67,7 +67,7 @@ sub list_remote {
 		$git->command(qw(config --get-regexp), '^remote\.');
 	};
 	for (@remotes) {
-		if (/^remote\.([^.]*)\.(\S*)\s+(.*)$/) {
+		if (/^remote\.(\S*)\.(fetch|url)\s+(.*)$/) {
 			add_remote_config(\%seen, $1, $2, $3);
 		}
 	}

             reply	other threads:[~2007-02-21  5:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-21  5:03 Pavel Roskin [this message]
2007-02-21  5:21 ` [PATCH] git-remote: support remotes with a dot in the name Junio C Hamano
2007-02-21  5:46   ` Pavel Roskin
2007-02-21  6:18     ` Junio C Hamano
2007-02-21  7:12       ` Pavel Roskin
2007-02-21  7:29         ` Shawn O. Pearce
2007-02-21  7:32         ` Junio C Hamano
2007-02-21 10:21       ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070221050336.26431.46485.stgit@dv.roinet.com \
    --to=proski@gnu.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).