git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <junkio@cox.net>,
	"Francis Moreau" <francis.moro@gmail.com>
Subject: Re: git-am failed, what's next ?
Date: Thu, 22 Feb 2007 11:13:42 +0000	[thread overview]
Message-ID: <200702221113.44338.andyparkins@gmail.com> (raw)
In-Reply-To: <7v8xeqh6bj.fsf@assigned-by-dhcp.cox.net>

On Thursday 2007 February 22 09:47, Junio C Hamano wrote:

> If you have the pre-image blobs the patch was created against,
> and the patch was created with git and records "index" lines
> like these correctly:
>
>         diff --git a/builtin-config.c b/builtin-config.c
>         index 0f9051d..f1433a4 100644
>
> then you can tell git to fall back on 3-way merge to apply the
> patch.  After seeing "git am ./mbox" fail, you could try

Magic.  I had no idea about this.  Could it be made even more magical by doing 
this for you?

git-am would know if the patch that failed is a git-generated patch, so when 
things go wrong, before bombing out it could try a 3-way merge.  It's much 
easier to resolve faults with the usual conflict markers than reading 
patches.  It's also possible that the 3-way merge will succeed and git-am 
will continue without ever needing to worry the user.


Andy
-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com

  parent reply	other threads:[~2007-02-22 11:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-22  8:22 git-am failed, what's next ? Francis Moreau
2007-02-22  8:48 ` Andy Parkins
2007-02-22 10:09   ` Francis Moreau
2007-02-22  9:47 ` Junio C Hamano
2007-02-22 10:38   ` Francis Moreau
2007-02-22 19:30     ` Junio C Hamano
2007-02-22 10:50   ` Francis Moreau
2007-02-22 11:13   ` Andy Parkins [this message]
2007-02-22 20:02     ` Junio C Hamano
2007-02-22 19:11 ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702221113.44338.andyparkins@gmail.com \
    --to=andyparkins@gmail.com \
    --cc=francis.moro@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).