git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Junio C Hamano <junkio@cox.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	johan defries <johandefries@gmail.com>,
	git@vger.kernel.org
Subject: Re: strange date generated by git-format-patch
Date: Sat, 24 Feb 2007 08:08:39 -0500	[thread overview]
Message-ID: <20070224130839.GC4380@thunk.org> (raw)
In-Reply-To: <7vodnjzyvq.fsf@assigned-by-dhcp.cox.net>

On Sat, Feb 24, 2007 at 01:30:17AM -0800, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >> That is just a fake random date to make the Unix-From line recognizable 
> >> by common MUA and does not have anything to do with your commit objects.
> >
> I do not think it is worth changing it.  Who's hurting with the
> current behaviour?  In other words, is it broken?  Unix-From
> lines are there only to separate each piece of e-mail in the
> mbox and otherwise is not used.  send-email, am, nor imap-send
> should care anything beyond the leading "From ", and mailsplit
> validates only that what's around the last colon near the end of
> line looks like time and year.

The only potential problem with it is that some MUA's (like mutt for
example) sort by the From date by default.  You can force it to list
the patches in an unsorted order (via 'Ou'), but it might be nice if
the patches date in the From field was the date that the patches were
generated, with the seconds field bumped so that the patches in a
series were guaranteed to have monotonically increasing dates.  It's
only a minor point, though.

						- Ted

  reply	other threads:[~2007-02-24 13:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-23  8:55 strange date generated by git-format-patch johan defries
2007-02-23  9:04 ` Junio C Hamano
2007-02-23 14:59   ` Johannes Schindelin
2007-02-24  9:30     ` Junio C Hamano
2007-02-24 13:08       ` Theodore Tso [this message]
2007-02-24 18:51         ` Jeff King
2007-02-24 23:19       ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070224130839.GC4380@thunk.org \
    --to=tytso@mit.edu \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=johandefries@gmail.com \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).