From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shawn O. Pearce" Subject: Re: [PATCH 5/6] convert object type handling from a string to a number Date: Tue, 27 Feb 2007 10:01:26 -0500 Message-ID: <20070227150126.GA3230@spearce.org> References: <11725197603476-git-send-email-nico@cam.org> <1172519760216-git-send-email-nico@cam.org> <11725197613482-git-send-email-nico@cam.org> <11725197622423-git-send-email-nico@cam.org> <11725197633144-git-send-email-nico@cam.org> <11725197632516-git-send-email-nico@cam.org> <7vejobhor2.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nicolas Pitre , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Tue Feb 27 21:44:12 2007 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1HM9BD-0000mq-W1 for gcvg-git@gmane.org; Tue, 27 Feb 2007 21:44:12 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933108AbXB0Unj (ORCPT ); Tue, 27 Feb 2007 15:43:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933106AbXB0Unj (ORCPT ); Tue, 27 Feb 2007 15:43:39 -0500 Received: from corvette.plexpod.net ([64.38.20.226]:45634 "EHLO corvette.plexpod.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933108AbXB0Uni (ORCPT ); Tue, 27 Feb 2007 15:43:38 -0500 X-Greylist: delayed 657 seconds by postgrey-1.27 at vger.kernel.org; Tue, 27 Feb 2007 15:43:33 EST Received: from cpe-74-70-48-173.nycap.res.rr.com ([74.70.48.173] helo=asimov.home.spearce.org) by corvette.plexpod.net with esmtpa (Exim 4.63) (envelope-from ) id 1HM3pT-0005SX-A5; Tue, 27 Feb 2007 10:01:23 -0500 Received: by asimov.home.spearce.org (Postfix, from userid 1000) id E492F20FBAE; Tue, 27 Feb 2007 10:01:26 -0500 (EST) Content-Disposition: inline In-Reply-To: <7vejobhor2.fsf@assigned-by-dhcp.cox.net> User-Agent: Mutt/1.5.11 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - corvette.plexpod.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - spearce.org X-Source: X-Source-Args: X-Source-Dir: Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Junio C Hamano wrote: > I am wondering if "enum object_type" and signed comparison here > are compatible. sha1_object_info() is of type "int" so that is > clearly signed, but are we safe assuming this would not result > in "type is unsigned and condition is always false"? See my recent patch; I actually rewrote those hunks to use OBJ_BAD rather than < 0, as this cleans things up for my packv4. -- Shawn.