From: Robin Rosenberg <robin.rosenberg@dewire.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [EGIT PATCH 6/9] Add branch and StGit patch to decorator
Date: Thu, 1 Mar 2007 09:22:17 +0100 [thread overview]
Message-ID: <200703010922.18149.robin.rosenberg@dewire.com> (raw)
In-Reply-To: <20070301035909.GA8103@spearce.org>
torsdag 01 mars 2007 04:59 skrev Shawn O. Pearce:
> Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> > + public String getPatch() throws IOException {
> > + final File ptr = new File(getDirectory(),"patches/"+getBranch()+"/current");
> > + final BufferedReader br = new BufferedReader(new FileReader(ptr));
> > + final String line = br.readLine();
> > + return line;
> > + }
>
> Last time I checked leaking a file descriptor was a bad idea.
It's a hallmark of mine. Sooner or later the GC picks them up :), but you're right.
> I fixed it (in both methods) when I applied the patch.
>
> Your whole series is now pushed. Thanks for the cleanups.
>
-- robin
next prev parent reply other threads:[~2007-03-01 8:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 22:26 [EGIT PATCH 0/9] Misc minor fixes Robin Rosenberg
2007-02-28 22:26 ` [EGIT PATCH 1/9] Minor fix Robin Rosenberg
2007-02-28 22:26 ` [EGIT PATCH 2/9] Catch mmap errors and retry Robin Rosenberg
2007-02-28 22:26 ` [EGIT PATCH 3/9] Use mmap per default Robin Rosenberg
2007-02-28 22:26 ` [EGIT PATCH 4/9] Add .qualifier to the plugin version Robin Rosenberg
2007-02-28 22:26 ` [EGIT PATCH 5/9] Force full checkpoint for CheckpointOperation Robin Rosenberg
2007-02-28 22:26 ` [EGIT PATCH 6/9] Add branch and StGit patch to decorator Robin Rosenberg
2007-03-01 3:59 ` Shawn O. Pearce
2007-03-01 8:22 ` Robin Rosenberg [this message]
2007-02-28 22:26 ` [EGIT PATCH 7/9] Support tag objects Robin Rosenberg
2007-02-28 22:26 ` [EGIT PATCH 8/9] Handle odd tag formats created by tools such as cvsimport Robin Rosenberg
2007-02-28 22:26 ` [EGIT PATCH 9/9] Performance test for jgit Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703010922.18149.robin.rosenberg@dewire.com \
--to=robin.rosenberg@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).