From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eygene Ryabinkin Subject: Re: Memory overrun in http-push.c Date: Thu, 1 Mar 2007 15:00:42 +0300 Message-ID: <20070301120042.GD63606@codelabs.ru> References: <20070228151516.GC57456@codelabs.ru> <81b0412b0703010015l5c91c68pd4748ae379db98bb@mail.gmail.com> <7vslcpux62.fsf@assigned-by-dhcp.cox.net> <200703011040.35971.andyparkins@gmail.com> <20070228151516.GC57456@codelabs.ru> <200702281541.41164.andyparkins@gmail.com> <20070301051323.GG57456@codelabs.ru> <81b0412b0703010015l5c91c68pd4748ae379db98bb@mail.gmail.com> <7vslcpux62.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Cc: Alex Riesen , git@vger.kernel.org, Johannes Schindelin To: Junio C Hamano , Andy Parkins X-From: git-owner@vger.kernel.org Thu Mar 01 13:01:23 2007 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1HMjyM-00088s-NZ for gcvg-git@gmane.org; Thu, 01 Mar 2007 13:01:23 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965025AbXCAMAv (ORCPT ); Thu, 1 Mar 2007 07:00:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965030AbXCAMAv (ORCPT ); Thu, 1 Mar 2007 07:00:51 -0500 Received: from pobox.codelabs.ru ([144.206.177.45]:62160 "EHLO pobox.codelabs.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965025AbXCAMAu (ORCPT ); Thu, 1 Mar 2007 07:00:50 -0500 Received: from codelabs.ru (pobox.codelabs.ru [144.206.177.45]) by pobox.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256) id 1HMjxn-000GtT-NL; Thu, 01 Mar 2007 15:00:48 +0300 Content-Disposition: inline In-Reply-To: <200703011040.35971.andyparkins@gmail.com> <7vslcpux62.fsf@assigned-by-dhcp.cox.net> X-Spam-Status: No, score=-3.1 required=4.0 tests=ALL_TRUSTED,AWL,BAYES_00 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Good day! > was more annoyed by the fact that the patch was an attachment, > than it was generated by diff without leading a/ and b/ paths. So, git is unable to use this type of patches directly and I will need to do $ patch < patchfile $ rm file.orig $ git commit Just wondering what is bad with the diffs without leading a/ and b/. > I certainly wasn't suggesting that it should be a requirement. I just thought > there was a certain irony. Perhaps even a lesson to be learned - find out > why someone has chosen (even with git in front of them and deep enough inside > to find bugs in it), not to use git. I've just realized that I need git because I need disconnected commits. That's why I left my beloved SVN and started to hack GIT ;)) By the way, I am missing one thing: the Id keyword in the file. The problem is that when some user is telling me: there is a bug in the function a() that is inside the file b.c, then I can ask him to give me the $Id$ tag of the file and I will have the full information about the file version. Can I have it with git if user has just the sources without any signs of the file versions? I've glanced over the git manual, but was unable to find anything usable. > I think there is a usability lesson to be pulled from this situation. Why > didn't Eygene just say: > > $ tar zxvf git-tarball.tgz > $ cd git > $ git init > $ vim http-push.c > $ git diff > > Note, that was not an attack on Eygene - I genuinely am interested to know > where we should put the documentation that tells a new user what they need to > know quickly. > > Somehow, git has failed this person. I was simply wondering in what way. > > However, Eygene's response made it sound like a situational thing - it was > inconvenient to actually install git. Fair enough. Not incovinient to install git, but it was just convinient to me to use FreeBSD port. The other way round ;)) -- Eygene