From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Daniel Walker <dwalker@mvista.com>,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
linux-pm@lists.osdl.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Avi Kivity <avi@qumranet.com>, Adrian Bunk <bunk@stusta.de>,
Pavel Machek <pavel@ucw.cz>, Jens Axboe <jens.axboe@oracle.com>,
"Michael S. Tsirkin" <mst@mellanox.co.il>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
git@vger.kernel.org
Subject: [patch] KVM: T60 resume fix
Date: Fri, 2 Mar 2007 11:22:16 +0100 [thread overview]
Message-ID: <20070302102216.GA13575@elte.hu> (raw)
In-Reply-To: <20070302102018.GA11549@elte.hu>
Subject: [patch] KVM: T60 resume fix
From: Ingo Molnar <mingo@elte.hu>
my T60 laptop does not resume correctly due to KVM attempting to send an
IPI to a CPU that might be down (or not up yet). (Doing so also triggers
the send_IPI_mask_bitmask() warning in arch/i386/kernel/smp.c, line
732.)
with this fix applied my laptop does not hang during resume.
[ KVM will have to disable/enable virtualization on the CPU itself that
goes down / comes up, not via an IPI sent from the requesting CPU. ]
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
drivers/kvm/kvm_main.c | 6 ------
1 file changed, 6 deletions(-)
Index: linux/drivers/kvm/kvm_main.c
===================================================================
--- linux.orig/drivers/kvm/kvm_main.c
+++ linux/drivers/kvm/kvm_main.c
@@ -2083,12 +2083,6 @@ static int kvm_cpu_hotplug(struct notifi
case CPU_DEAD:
case CPU_UP_CANCELED:
decache_vcpus_on_cpu(cpu);
- smp_call_function_single(cpu, kvm_arch_ops->hardware_disable,
- NULL, 0, 1);
- break;
- case CPU_UP_PREPARE:
- smp_call_function_single(cpu, kvm_arch_ops->hardware_enable,
- NULL, 0, 1);
break;
}
return NOTIFY_OK;
next prev parent reply other threads:[~2007-03-02 10:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070227102109.GG6745@elf.ucw.cz>
[not found] ` <20070227103021.GA2250@kernel.dk>
[not found] ` <20070227103407.GA17819@elte.hu>
[not found] ` <20070227105922.GD2250@kernel.dk>
[not found] ` <20070227111515.GA4271@kernel.dk>
[not found] ` <20070301093450.GA8508@elte.hu>
[not found] ` <20070301104117.GA22788@elte.hu>
[not found] ` <20070301145204.GA25304@elte.hu>
[not found] ` <Pine.LNX.4.64.0703011536450.12485@woody.linux-foundation.org>
[not found] ` <20070302072100.GB30634@elte.hu>
2007-03-02 8:04 ` 2.6.21-rc1: known regressions (part 2) Ingo Molnar
2007-03-02 10:20 ` Ingo Molnar
2007-03-02 10:22 ` Ingo Molnar [this message]
2007-03-02 11:39 ` [patch] KVM: T60 resume fix Michael S. Tsirkin
2007-03-03 8:22 ` Avi Kivity
2007-03-03 8:21 ` Avi Kivity
2007-03-03 11:57 ` Andrew Morton
2007-03-05 8:22 ` Ingo Molnar
2007-03-05 10:23 ` Michael S. Tsirkin
2007-03-05 10:29 ` Ingo Molnar
2007-03-02 16:36 ` 2.6.21-rc1: known regressions (part 2) Linus Torvalds
2007-03-05 14:04 ` Ingo Molnar
2007-03-05 15:44 ` Michael S. Tsirkin
2007-03-05 16:14 ` Michael S. Tsirkin
2007-03-05 16:41 ` Ingo Molnar
2007-03-05 18:16 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070302102216.GA13575@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=avi@qumranet.com \
--cc=bunk@stusta.de \
--cc=dwalker@mvista.com \
--cc=git@vger.kernel.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=mst@mellanox.co.il \
--cc=pavel@ucw.cz \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).