From: Xavier Maillard <zedek@gnu.org>
To: Alexandre Julliard <julliard@winehq.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 5/7] Try to do things in the right order
Date: Mon, 5 Mar 2007 08:27:57 +0100 [thread overview]
Message-ID: <200703050727.l257Rv0k007635@localhost.localdomain> (raw)
In-Reply-To: <87ps7qty5l.fsf@wine.dyndns.org> (julliard@winehq.org)
From: Alexandre Julliard <julliard@winehq.org>
Xavier Maillard <zedek@gnu.org> writes:
> @@ -35,8 +36,14 @@
> (require 'vc)
> (require 'cl))
>
> -;; Add it automatically
> -(add-to-list 'vc-handled-backends 'GIT)
> +;; HACK: clear up the cache to force vc-call to check again and
> +;; discover new functions when we reload this file.
> +(put 'GIT 'vc-functions nil)
> +
> +;; Add it automatically when loading vc
> +;; FIXME: should be directly put into vc.el
> +(eval-after-load "vc"
> + '(add-to-list 'vc-handled-backends 'GIT))
That's ugly. Simply recommending that users set vc-handled-backends in
their .emacs is easier and cleaner, I still don't see why you want to
change it.
I'd rather want to just require or load vc-git (and that should
not be the way to go too since it should be automatically handled
by vc.el when vc-git will become part of GNU Emacs ).
By the way, do you plan to ask for inclusion into emacs ?
That's just a matter of taste, nothing more.
--
Xavier
prev parent reply other threads:[~2007-03-05 7:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-03 10:19 [PATCH 5/7] Try to do things in the right order Xavier Maillard
2007-03-03 10:32 ` Alexandre Julliard
2007-03-05 7:27 ` Xavier Maillard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703050727.l257Rv0k007635@localhost.localdomain \
--to=zedek@gnu.org \
--cc=git@vger.kernel.org \
--cc=julliard@winehq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).