git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Karl Hasselström" <kha@treskal.com>
To: Xavier Maillard <zedek@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Use non-interactive function to byte-compile files
Date: Mon, 5 Mar 2007 10:51:01 +0100	[thread overview]
Message-ID: <20070305095101.GA792@diana.vm.bytemark.co.uk> (raw)
In-Reply-To: <200703050823.l258NgT9008266@localhost.localdomain>

On 2007-03-05 09:23:42 +0100, Xavier Maillard wrote:

> Hi,
>
> Ihope this one is more closed to what you expect to see in a
> commit log.
>
> * contrib/emacs/Makefile: add git-blame as a candidate to the
>    	    byte-compilation.  batch-byte-compile is the prefered way
>    	    to byte-compile files in batch mode. Use it instead of the
>    	    interactive function.
>
> Signed-off-by: Xavier Maillard <zedek@gnu.org>
> ---
>  contrib/emacs/Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/emacs/Makefile b/contrib/emacs/Makefile

Unless you intended the "hi, I hope this is better" part to be part of
the commit message, you should put it after the "---"; otherwise,
Junio will have to fix it up by hand.

Yes, Documentation/SubmittingPatches is a loooong text ...

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle

  reply	other threads:[~2007-03-05  9:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-05  8:23 [PATCH] Use non-interactive function to byte-compile files Xavier Maillard
2007-03-05  9:51 ` Karl Hasselström [this message]
2007-03-05 14:54   ` Johannes Schindelin
2007-03-05 15:04     ` Karl Hasselström
2007-03-05 15:37       ` [PATCH] Begin SubmittingPatches with a check list Johannes Schindelin
2007-03-05 17:28         ` Alex Riesen
2007-03-05 20:52         ` Brian Gernhardt
2007-03-05 23:14           ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070305095101.GA792@diana.vm.bytemark.co.uk \
    --to=kha@treskal.com \
    --cc=git@vger.kernel.org \
    --cc=zedek@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).