From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: 2.6.21-rc1: known regressions (part 2) Date: Mon, 5 Mar 2007 17:41:33 +0100 Message-ID: <20070305164133.GA2441@elte.hu> References: <20070227103407.GA17819@elte.hu> <20070227105922.GD2250@kernel.dk> <20070227111515.GA4271@kernel.dk> <20070301093450.GA8508@elte.hu> <20070301104117.GA22788@elte.hu> <20070301145204.GA25304@elte.hu> <20070302072100.GB30634@elte.hu> <20070302080441.GA12785@elte.hu> <20070305161450.GA4972@mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: Daniel Walker , Michal Piotrowski , linux-pm@lists.osdl.org, Linux Kernel Mailing List , Adrian Bunk , Pavel Machek , Jens Axboe , Thomas Gleixner , Linus Torvalds , Andrew Morton , git@vger.kernel.org To: "Michael S. Tsirkin" X-From: linux-pm-bounces@lists.osdl.org Mon Mar 05 17:42:34 2007 Return-path: Envelope-to: gll-linux-pm@gmane.org Received: from smtp.osdl.org ([65.172.181.24]) by lo.gmane.org with esmtp (Exim 4.50) id 1HOGGE-0007aW-TE for gll-linux-pm@gmane.org; Mon, 05 Mar 2007 17:42:07 +0100 Received: from fire-2.osdl.org (localhost [127.0.0.1]) by smtp.osdl.org (8.12.8/8.12.8) with ESMTP id l25Gfqq8031648; Mon, 5 Mar 2007 08:41:53 -0800 Received: from mx2.mail.elte.hu (mx2.mail.elte.hu [157.181.151.9]) by smtp.osdl.org (8.12.8/8.12.8) with ESMTP id l25Gfkq8031642 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO) for ; Mon, 5 Mar 2007 08:41:48 -0800 Received: from elvis.elte.hu ([157.181.1.14]) by mx2.mail.elte.hu with esmtp (Exim) id 1HOGFk-0001b9-UD from ; Mon, 05 Mar 2007 17:41:40 +0100 Received: by elvis.elte.hu (Postfix, from userid 1004) id 5CDA93E2141; Mon, 5 Mar 2007 17:41:35 +0100 (CET) Content-Disposition: inline In-Reply-To: <20070305161450.GA4972@mellanox.co.il> User-Agent: Mutt/1.4.2.2i Received-SPF: pass (localhost is always allowed.) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.0.3 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] X-Spam-Status: No, hits=-2.503 required=5 tests=AWL,OSDL_HEADER_LISTID_KNOWN,OSDL_HEADER_SPF_PASS,OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 2.63-osdl_revision__1.119__ X-MIMEDefang-Filter: osdl$Revision: 1.176 $ X-BeenThere: linux-pm@lists.osdl.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: Linux power management List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.osdl.org Errors-To: linux-pm-bounces@lists.osdl.org Archived-At: * Michael S. Tsirkin wrote: > > Quoting Ingo Molnar : > > git-bisect good 0539771d7236b425f285652f6f297cc7939c8f9a > > = > > 81450b73dde07f473a4a7208b209b4c8b7251d90 is first bad commit > = > I have confirmed these two on my system. you could probably get quite a bit further in bisecting the other = breakage, by using the following method: manully apply the patch below to 81450b73dde and retest. It will most = likely work. Then FIRST unapply the patch and mark the tree via = 'git-bisect good' and continue the bisection. Then try to apply the = patch again. If it's already included - ignore the rejected patch. = Whenever git-bisect offers you a new commit, just try to apply the = patch. Ok? This way you'll be able to avoid the known ACPI breakage, and = zoom in on the unknown breakage. Ingo ----------------> commit f3ccb06f3b8e0cf42b579db21f3ca7f17fcc3f38 Author: Alexey Starikovskiy Date: Tue Feb 13 02:35:50 2007 -0500 ACPI: Disable wake GPEs only once. = fixes Suspend/Resume regressions due to recent ACPICA update. = Signed-off-by: Alexey Starikovskiy Signed-off-by: Len Brown diff --git a/drivers/acpi/events/evgpe.c b/drivers/acpi/events/evgpe.c index dfac3ec..635ba44 100644 --- a/drivers/acpi/events/evgpe.c +++ b/drivers/acpi/events/evgpe.c @@ -636,17 +636,6 @@ acpi_ev_gpe_dispatch(struct acpi_gpe_event_info *gpe_e= vent_info, u32 gpe_number) } } = - if (!acpi_gbl_system_awake_and_running) { - /* - * We just woke up because of a wake GPE. Disable any further GPEs - * until we are fully up and running (Only wake GPEs should be enabled - * at this time, but we just brute-force disable them all.) - * 1) We must disable this particular wake GPE so it won't fire again - * 2) We want to disable all wake GPEs, since we are now awake - */ - (void)acpi_hw_disable_all_gpes(); - } - /* * Dispatch the GPE to either an installed handler, or the control method * associated with this GPE (_Lxx or _Exx). If a handler exists, we invoke