From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: "Li Yang-r58472" <LeoLi@freescale.com>,
"Jeff King" <peff@peff.net>,
git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Change to use explicitly function call cgi->escapHTML()
Date: Tue, 6 Mar 2007 14:23:17 +0100 [thread overview]
Message-ID: <200703061423.18417.jnareb@gmail.com> (raw)
In-Reply-To: <7vzm6qps51.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Speaking of -title, I see "sub git_project_list_body" does this:
>
> $cgi->a({ ... -title => $pr->{'descr_long'}}, esc_html($pr->{'descr'}));
>
> which seems inconsistent with the earlier quoted $fullname
> handling (unless $pr->{'descr_long'} is already quoted and $pr->{'descr'}
> is not, which I find highly unlikely).
CGI::a() subroutine automatically quotes properly _attribute_ values,
but it does not (and it should not) quote _contents_ of a tag.
So the above code is correct.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2007-03-06 13:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 3:58 [PATCH] gitweb: Change to use explicitly function call cgi->escapHTML() Li Yang
2007-03-06 6:55 ` Junio C Hamano
2007-03-06 9:34 ` Jakub Narebski
2007-03-06 9:39 ` Jeff King
2007-03-06 9:46 ` Junio C Hamano
2007-03-06 10:31 ` Li Yang-r58472
2007-03-06 10:41 ` Jeff King
2007-03-06 10:53 ` Junio C Hamano
2007-03-06 10:56 ` Jeff King
2007-03-06 10:58 ` Junio C Hamano
2007-03-06 11:01 ` Jeff King
2007-03-06 11:05 ` Junio C Hamano
2007-03-06 11:07 ` Jeff King
2007-03-06 11:07 ` Li Yang-r58472
2007-03-06 10:45 ` Junio C Hamano
2007-03-06 13:23 ` Jakub Narebski [this message]
2007-03-06 23:17 ` Junio C Hamano
2007-03-07 0:37 ` Jakub Narebski
2007-03-07 0:49 ` Junio C Hamano
2007-03-07 1:21 ` [PATCH] gitweb: Don't escape attributes in CGI.pm HTML methods Jakub Narebski
2007-03-07 1:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703061423.18417.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=LeoLi@freescale.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).