* [PATCH 1/9] Display the null SHA-1 as the base for an OBJ_OFS_DELTA.
@ 2007-03-07 1:44 Shawn O. Pearce
0 siblings, 0 replies; only message in thread
From: Shawn O. Pearce @ 2007-03-07 1:44 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Because we are currently cheating and never supplying the delta base
for an OBJ_OFS_DELTA we get a random SHA-1 in the delta base field.
Instead lets clear the hash out so its at least all 0's. This is
somewhat more obvious that something fishy is going on, like we
don't actually have the SHA-1 of the base handy. :)
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
sha1_file.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sha1_file.c b/sha1_file.c
index 6d0a72e..c13ef66 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -1200,6 +1200,7 @@ const char *packed_object_info_detail(struct packed_git *p,
obj_offset = get_delta_base(p, &w_curs, &curpos, type, obj_offset);
if (*delta_chain_length == 0) {
/* TODO: find base_sha1 as pointed by curpos */
+ hashclr(base_sha1);
}
break;
case OBJ_REF_DELTA:
--
1.5.0.3.863.gf0989
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-03-07 1:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-07 1:44 [PATCH 1/9] Display the null SHA-1 as the base for an OBJ_OFS_DELTA Shawn O. Pearce
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).