From: "Shawn O. Pearce" <spearce@spearce.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, junkio@cox.net, Mark Levedahl <mlevedahl@gmail.com>
Subject: Re: [PATCH 3/3] git-bundle: prevent overwriting existing bundles
Date: Thu, 8 Mar 2007 21:59:02 -0500 [thread overview]
Message-ID: <20070309025902.GE32211@spearce.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0703090348480.22628@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> if (bundle_fd < 0)
> - return error("Could not write to '%s'", path);
> + return error("Could not create '%s'", path);
I hate to be a nit, but what about?
> + return error("Could not create '%s': %s", path, strerror(errno));
--
Shawn.
next prev parent reply other threads:[~2007-03-09 2:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 2:50 [PATCH 3/3] git-bundle: prevent overwriting existing bundles Johannes Schindelin
2007-03-09 2:59 ` Shawn O. Pearce [this message]
2007-03-09 3:05 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070309025902.GE32211@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=mlevedahl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox