From: Matthias Lederhofer <matled@gmx.net>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-init: set up GIT_DIR/workdir if GIT_WORK_DIR is set
Date: Mon, 12 Mar 2007 19:08:37 +0100 [thread overview]
Message-ID: <20070312180837.GA22701@moooo.ath.cx> (raw)
In-Reply-To: <7vabyitlld.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> Matthias Lederhofer <matled@gmx.net> writes:
>
> > ... because
> > $GIT_WORK_DIR is normally interpreted as relative path to the current
> > working directory and not relative to $GIT_DIR.
>
> Well, it could be that _that_ handling of the environment
> variable is what needs to be fixed.
You're right, this seems to be much better.
I just thought that GIT_WORK_DIR should be relative to the current
working directory because it's more intuitive, e.g.
$ git --git-dir=/path/to/repo.git --work-dir=../.. add a
where ../.. matches the path to the toplevel working directory from
cwd. But this definitely is annoying when changing directories.
I'll go and fix this. Do you prefer an amended patch or just a patch
on top?
next prev parent reply other threads:[~2007-03-12 18:08 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-11 4:32 [RFC] introduce GIT_WORK_DIR environment variable Matthias Lederhofer
2007-03-11 5:34 ` Junio C Hamano
2007-03-11 8:26 ` Andy Parkins
2007-03-11 16:22 ` Matthias Lederhofer
2007-03-11 20:10 ` Junio C Hamano
2007-03-11 21:43 ` Johannes Schindelin
2007-03-11 20:37 ` Linus Torvalds
2007-03-11 21:04 ` Junio C Hamano
2007-03-11 21:13 ` Linus Torvalds
2007-03-12 8:08 ` A.J. Rossini
2007-04-01 7:42 ` Andy Parkins
2007-03-11 12:42 ` Nguyen Thai Ngoc Duy
2007-03-11 13:33 ` Matthias Lederhofer
2007-03-11 13:46 ` Nguyen Thai Ngoc Duy
2007-03-11 14:05 ` Matthias Lederhofer
2007-03-11 14:18 ` Nguyen Thai Ngoc Duy
2007-03-11 15:56 ` [PATCH(amend)] " Matthias Lederhofer
2007-03-11 16:25 ` Nguyen Thai Ngoc Duy
2007-03-11 21:29 ` [PATCH] use $GIT_DIR/workdir as working directory with $GIT_DIR Matthias Lederhofer
2007-03-13 23:10 ` [PATCH] core.workdir config variable Matthias Lederhofer
2007-03-13 23:57 ` [PATCH(amend)] " Matthias Lederhofer
2007-03-14 6:01 ` Shawn O. Pearce
2007-03-14 7:48 ` Junio C Hamano
2007-03-14 14:20 ` Shawn O. Pearce
2007-03-11 13:27 ` [RFC] introduce GIT_WORK_DIR environment variable Nguyen Thai Ngoc Duy
2007-03-11 15:05 ` [PATCH] rev-parse: --is-bare-repository option Matthias Lederhofer
2007-03-12 11:53 ` [PATCH] git-init: set up GIT_DIR/workdir if GIT_WORK_DIR is set Matthias Lederhofer
2007-03-12 12:12 ` Joshua N Pritikin
2007-03-12 12:52 ` Matthias Lederhofer
2007-03-12 13:12 ` Matthias Lederhofer
2007-03-12 13:36 ` Nguyen Thai Ngoc Duy
2007-03-12 14:08 ` Matthias Lederhofer
2007-03-12 17:31 ` Junio C Hamano
2007-03-12 18:08 ` Matthias Lederhofer [this message]
2007-03-12 19:18 ` [PATCH] always interpret GIT_WORK_DIR relative to $GIT_DIR Matthias Lederhofer
2007-03-12 19:53 ` [PATCH] GIT_WORK_DIR: documentation for relative path Matthias Lederhofer
2007-03-12 20:05 ` [PATCH] git-init: set up GIT_DIR/workdir if GIT_WORK_DIR is set Junio C Hamano
2007-03-12 20:40 ` Matthias Lederhofer
2007-03-12 19:23 ` [PATCH(amend)] " Matthias Lederhofer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070312180837.GA22701@moooo.ath.cx \
--to=matled@gmx.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).