From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Lederhofer Subject: Re: [PATCH 3/5] introduce GIT_WORK_TREE environment variable Date: Sun, 18 Mar 2007 21:23:02 +0100 Message-ID: <20070318202302.GA5191@moooo.ath.cx> References: <20070317015855.GB19305@moooo.ath.cx> <7vbqiss4yw.fsf@assigned-by-dhcp.cox.net> <20070317143452.GA21140@moooo.ath.cx> <20070317144403.GC26290@moooo.ath.cx> <20070318201209.GA1968@moooo.ath.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Junio C Hamano , git@vger.kernel.org X-From: git-owner@vger.kernel.org Sun Mar 18 21:23:13 2007 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1HT1uH-0000xs-Sy for gcvg-git@gmane.org; Sun, 18 Mar 2007 21:23:10 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750844AbXCRUXI (ORCPT ); Sun, 18 Mar 2007 16:23:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751134AbXCRUXI (ORCPT ); Sun, 18 Mar 2007 16:23:08 -0400 Received: from mail.gmx.net ([213.165.64.20]:48116 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750844AbXCRUXF (ORCPT ); Sun, 18 Mar 2007 16:23:05 -0400 Received: (qmail invoked by alias); 18 Mar 2007 20:23:03 -0000 X-Provags-ID: V01U2FsdGVkX18fbcJc8qwf2f+mzsRSdl3+rh7W/ogFQzmKQ+T28w BggoqhdRs4Eghl Mail-Followup-To: Junio C Hamano , git@vger.kernel.org Content-Disposition: inline In-Reply-To: <20070318201209.GA1968@moooo.ath.cx> X-Y-GMX-Trusted: 0 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Matthias Lederhofer wrote: > Matthias Lederhofer wrote: > > + inside_working_tree = !prefixcmp(cwd, worktree); > [..] > > + inside_git_dir = !prefixcmp(cwd, gitdir); > > This time a real bug: the parameters have to be the other way around. Sorry, it was right. prefixcmp got me confused again when doing some testing and the result wasn't what I expected. I'll go and copy&paste 100 times !prefixcmp(str, prefix) means "begins str with prefix?"