git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Pavel Roskin <proski@gnu.org>,
	Git Mailing List <git@vger.kernel.org>,
	Alexander Litvinov <litvinov2004@gmail.com>
Subject: Re: git 1.5.1-rc1 doesn't like empty files
Date: Tue, 20 Mar 2007 01:56:11 -0400	[thread overview]
Message-ID: <20070320055611.GD29288@spearce.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0703192237100.6730@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Tue, 20 Mar 2007, Pavel Roskin wrote:
> > 
> > .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391 is the same 9
> > bytes:  30 78 9c 03 00 00 00 00 01
> 
> Ahh.. You have
> 
> 	[core]
> 		legacyheaders = false
> 
> don't you? If you didn't, you should see a 15-byte object, not a 9-byte 
> one.
> 
> And yes, I can reproduce this with that "core.legacyheaders=false" 
> setting. It seems that config option is simply broken, and we never 
> noticed, because almost nobody uses it.

For what it is worth, I have been running core.legacyheaders=false
on both my PowerBook (my main dev system) and on my x86 Cygwin
POS.  I guess I've been lucky, as I've never noticed any sort
of corruption.

Oh, wait, yes I did.  Just the other day.  A loose object got the
same zlib error as Pavel asked about.  But git-prune whacked the
damn thing.  I figured it was just a short write by Cygwin during
some sort of operation that I may have aborted; e.g. aborting an
update-index and running it again later, thus never actually using
that particular blob.

I didn't think twice about the error (until now), especially since
`git-fsck --full` did not whine after the corrupt loose object
was gone.

-- 
Shawn.

  parent reply	other threads:[~2007-03-20  5:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-20  3:30 git 1.5.1-rc1 doesn't like empty files Pavel Roskin
2007-03-20  4:24 ` Nicolas Vilz
2007-03-20  4:54 ` Linus Torvalds
2007-03-20  5:08   ` Pavel Roskin
2007-03-20  5:41     ` Linus Torvalds
2007-03-20  5:50       ` Pavel Roskin
2007-03-20  5:56       ` Shawn O. Pearce [this message]
2007-03-20  7:04       ` Alexander Litvinov
2007-03-20  8:43       ` Andy Parkins
2007-03-20  8:49         ` Junio C Hamano
2007-03-20  9:26           ` Andy Parkins
2007-03-20 15:45             ` Linus Torvalds
2007-03-20  5:29 ` Junio C Hamano
2007-03-20  5:47   ` Pavel Roskin
2007-03-20  5:49   ` Linus Torvalds
2007-03-20  6:00     ` Junio C Hamano
2007-03-20  6:05       ` Junio C Hamano
2007-03-20 15:46         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070320055611.GD29288@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=litvinov2004@gmail.com \
    --cc=proski@gnu.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).