git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Cc: "Francis Moreau" <francis.moro@gmail.com>
Subject: Re: [PATCH] update-hook: remove all functionality that should be in hooks/post-receive
Date: Sun, 25 Mar 2007 09:11:51 +0000	[thread overview]
Message-ID: <200703251011.53712.andyparkins@gmail.com> (raw)
In-Reply-To: <38b2ab8a0703241115q39dc298clb15357268288b49e@mail.gmail.com>

On Saturday 2007, March 24, Francis Moreau wrote:

> yes that almost would do the thing. But instead of hacking the hook,
> it would be great to have a trivial setup at the begining of the
> script to choose this config.

I'd like Junio's permission before actually doing that; I know he is 
worried about out-of-control growth of hook scripts and it's already 
overly large just to do the one job it's got.

> Maybe a local config in the repo through the command `git config`
> could do the job ?
>
> $ git config hook.update.path "/var/www/"
>
> And if the config is to write the message to a file, skip the email
> stuffs generation (header, foorter...).

Again; it's not hard to do, and I don't mind adding it, but I don't want 
to set off Junio's bloat detector.  Bear in mind also that in the 
example you ask for every repo user would need write access 
to "/var/www"; because the hook script runs as the user performing the 
push.


Andy
-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com

  reply	other threads:[~2007-03-25  9:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-23 10:21 [PATCH] update-hook: remove all functionality that should be in hooks/post-receive Andy Parkins
2007-03-24  1:09 ` Junio C Hamano
2007-03-24  3:23   ` Linus Torvalds
2007-03-24  3:28   ` Shawn O. Pearce
2007-03-24  8:14   ` Andy Parkins
2007-03-24 10:26     ` Theodore Tso
2007-03-24 10:41       ` Junio C Hamano
2007-03-24 12:44         ` Andy Parkins
2007-03-24 14:21         ` Theodore Tso
2007-03-24 14:43 ` Francis Moreau
2007-03-24 15:48   ` Andy Parkins
2007-03-24 18:15     ` Francis Moreau
2007-03-25  9:11       ` Andy Parkins [this message]
2007-03-25  9:25         ` Shawn O. Pearce
2007-03-25 14:04         ` Francis Moreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200703251011.53712.andyparkins@gmail.com \
    --to=andyparkins@gmail.com \
    --cc=francis.moro@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).