From: Eygene Ryabinkin <rea-git@codelabs.ru>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/5] Consistently use user-defined UI font everywhere in GUI tools.
Date: Mon, 26 Mar 2007 14:16:10 +0400 [thread overview]
Message-ID: <20070326101610.GX14837@codelabs.ru> (raw)
In-Reply-To: <7vr6rcxv5x.fsf@assigned-by-dhcp.cox.net>
Junio,
Mon, Mar 26, 2007 at 01:31:54AM -0700, Junio C Hamano wrote:
> I think this is sane in general, but please
>
> (1) do not make a combined patch that covers gitk and git-gui
> at the same time;
I assume this does not the general rule, but it is just a consequence
of a gitk and git-gui being maintained by the different programmers?
I've always thought that the logically related changes should go
into the same commit.
> (2) address gitk patches to Paul Mackerras <paulus@samba.org>,
> with cc: the list;
>
> (3) address git-gui patches to Shawn Pearce <spearce@spearce.org>
> with cc: the list.
OK, will do.
Probably the RTFM question: can I redo my patches to split them up
to the different pieces for the gitk and git-gui in some automated
way? Or I will need to do it manually?
Thanks!
--
Eygene
prev parent reply other threads:[~2007-03-26 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-26 7:37 [PATCH 1/5] Consistently use user-defined UI font everywhere in GUI tools Eygene Ryabinkin
2007-03-26 8:31 ` Junio C Hamano
2007-03-26 10:06 ` Frank Lichtenheld
2007-03-26 10:16 ` Eygene Ryabinkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070326101610.GX14837@codelabs.ru \
--to=rea-git@codelabs.ru \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).