git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eygene Ryabinkin <rea-git@codelabs.ru>
To: Junio C Hamano <junkio@cox.net>
Cc: Jakub Narebski <jnareb@gmail.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git@vger.kernel.org
Subject: Re: [PATCH] Added options NO_TCLTK, WITH_P4IMPORT and --with-tcltk/--without-tcltk.
Date: Tue, 27 Mar 2007 10:59:40 +0400	[thread overview]
Message-ID: <20070327065940.GC51155@codelabs.ru> (raw)
In-Reply-To: <7vejnbtjdq.fsf@assigned-by-dhcp.cox.net>

Junio, good day.

Mon, Mar 26, 2007 at 09:12:17PM -0700, Junio C Hamano wrote:
> Eygene Ryabinkin <rea-git@codelabs.ru> writes:
> 
> > Mon, Mar 26, 2007 at 01:36:49AM -0700, Junio C Hamano wrote:
> > ...
> >> Thanks for sanity checking.  That means that the absense of
> >> tcltk would make it impossible to munge the scripts to point at
> >> the wish binary, so makes the NO_TCLTK stuff easier to swallow.
> >
> > Sorry, did not get the point. The TCLTK is initialized to the 'wish'
> > by 'TCLTK ?= wish', so TCLTK will always be here and initialized
> > to the wish by-default.
> 
> Earlier I said I did not see a reason for not building wish
> applications on a build system that lack them.  I am stating
> that you could argue that your rewriting the path to wish is a
> good reason (I would say it is half-good, as you can still tell
> the build procedure where wish will be on the deployed system
> without having it on your build system) for not building wish
> applications in a build that lacks wish installation.

OK, so, probably, I should modify the behaviour of the --with-tcltk
and configure to look for the Tcl/Tk interpreter _only_ if
--with-tcltk[=PATH] was given and to leave the things unmodified
in the case of absence of that option. But still, --without-tcltk
will disable Tcl/Tk dependant parts. Will people be happy with such
behaviour?
-- 
Eygene

  reply	other threads:[~2007-03-27  6:59 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-20 11:45 [PATCH] Added make options NO_GUI and WITH_P4IMPORT Eygene Ryabinkin
2007-03-21  0:35 ` Jakub Narebski
2007-03-21  5:14   ` Eygene Ryabinkin
2007-03-21 11:16     ` Johannes Schindelin
2007-03-21 11:50       ` Eygene Ryabinkin
2007-03-21 14:25         ` Johannes Schindelin
2007-03-21 14:38           ` Paolo Bonzini
2007-03-21 14:42             ` Eygene Ryabinkin
2007-03-21 14:49               ` Paolo Bonzini
2007-03-21 14:58               ` Alex Riesen
2007-03-24 23:16                 ` Jakub Narebski
2007-03-21 14:40           ` Eygene Ryabinkin
2007-03-21 15:35             ` Johannes Schindelin
2007-03-21 16:01               ` Eygene Ryabinkin
2007-03-21 16:17                 ` Junio C Hamano
2007-03-26  7:31                   ` Eygene Ryabinkin
2007-03-26  7:32                     ` [PATCH] Added options NO_TCLTK, WITH_P4IMPORT and --with-tcltk/--without-tcltk Eygene Ryabinkin
2007-03-26  8:27                       ` Junio C Hamano
2007-03-27 10:26                         ` [PATCH] Add the WITH_P4IMPORT knob to the Makefile Eygene Ryabinkin
2007-03-27 10:54                           ` Junio C Hamano
2007-03-27 11:22                             ` Eygene Ryabinkin
2007-03-27 11:25                               ` [PATCH] Added git-p4 package to the list of git RPMs Eygene Ryabinkin
2007-03-27 16:03                                 ` [PATCH] Remove unused WITH_OWN_SUBPROCESS_PY from RPM spec Brian Gernhardt
2007-04-04 18:30                                 ` [PATCH] Added git-p4 package to the list of git RPMs Junio C Hamano
2007-04-05 12:50                                   ` Eygene Ryabinkin
2007-03-26  8:30                       ` [PATCH] Added options NO_TCLTK, WITH_P4IMPORT and --with-tcltk/--without-tcltk Jakub Narebski
2007-03-26  8:36                         ` Junio C Hamano
2007-03-26 10:03                           ` Eygene Ryabinkin
2007-03-27  4:12                             ` Junio C Hamano
2007-03-27  6:59                               ` Eygene Ryabinkin [this message]
2007-03-27 10:24                                 ` [PATCH] Added configure options --with-tcltk/--without-tcltk Eygene Ryabinkin
2007-03-27 10:53                                   ` Junio C Hamano
2007-03-27 11:07                                     ` Eygene Ryabinkin
2007-03-28  1:52                                       ` Junio C Hamano
2007-03-28  9:12                                         ` [PATCH] Add --with-tcltk and --without-tcltk to configure Eygene Ryabinkin
2007-03-28  9:13                                           ` [PATCH] Added Tcl/Tk interpreter path rewriting for the GUI tools Eygene Ryabinkin
2007-03-28 19:48                                           ` [PATCH] Add --with-tcltk and --without-tcltk to configure Junio C Hamano
2007-03-29  7:44                                             ` Eygene Ryabinkin
2007-03-29  8:00                                               ` Junio C Hamano
2007-03-29  8:29                                                 ` Eygene Ryabinkin
2007-03-29  8:35                                                   ` Junio C Hamano
2007-03-29  8:58                                                     ` Eygene Ryabinkin
2007-03-29  9:12                                                       ` Tom Prince
2007-03-29 10:06                                                         ` Eygene Ryabinkin
2007-03-29 10:06                                                           ` [PATCH] Eliminate checks of user-specified Tcl/Tk interpreter Eygene Ryabinkin
2007-03-29 10:07                                               ` [PATCH] Added correct Python path to the RPM specfile Eygene Ryabinkin
2007-03-26  8:25                     ` [PATCH] Added make options NO_GUI and WITH_P4IMPORT Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070327065940.GC51155@codelabs.ru \
    --to=rea-git@codelabs.ru \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).